github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15120] [MERGED] mac: prevent generate on cross-compiles #61734

New Issue
Closed
opened 2026-04-29 16:45:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:45:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15120
Author: @dhiltgen
Created: 3/28/2026
Status: ✅ Merged
Merged: 4/13/2026
Merged by: @dhiltgen

Base: main ← Head: mac_cross

📝 Commits (1)

  • a5d1d00 mac: prevent generate on cross-compiles

📊 Changes

1 file changed (+24 additions, -14 deletions)

View changed files

📝 x/imagegen/mlx/CMakeLists.txt (+24 -14)

📄 Description

For some versions of Xcode, cmake builds are failing due to header problems in cross-compiling during the generate phase. Since generate is producing arch independent generated output, we can skip this during cross-compiling.

Failure mode without this:

./scripts/build_darwin.sh

....

Generated mlx.h and mlx.c successfully
# runtime/cgo
_cgo_export.c:3:10: fatal error: 'stdlib.h' file not found
x/mlxrunner/mlx/mlx.go:3: running "go": exit status 1
CMake Error at x/imagegen/mlx/CMakeLists.txt:118 (execute_process):
  execute_process failed command indexes:

    1: "Child return code: 1"



-- Configuring incomplete, errors occurred!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15120 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 3/28/2026 **Status:** ✅ Merged **Merged:** 4/13/2026 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `mac_cross` --- ### 📝 Commits (1) - [`a5d1d00`](https://github.com/ollama/ollama/commit/a5d1d00b452db9761affb056efc60bcfad0d9f60) mac: prevent generate on cross-compiles ### 📊 Changes **1 file changed** (+24 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `x/imagegen/mlx/CMakeLists.txt` (+24 -14) </details> ### 📄 Description For some versions of Xcode, cmake builds are failing due to header problems in cross-compiling during the generate phase. Since generate is producing arch independent generated output, we can skip this during cross-compiling. Failure mode without this: ``` ./scripts/build_darwin.sh .... Generated mlx.h and mlx.c successfully # runtime/cgo _cgo_export.c:3:10: fatal error: 'stdlib.h' file not found x/mlxrunner/mlx/mlx.go:3: running "go": exit status 1 CMake Error at x/imagegen/mlx/CMakeLists.txt:118 (execute_process): execute_process failed command indexes: 1: "Child return code: 1" -- Configuring incomplete, errors occurred! ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:45:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#61734
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?