github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-22 13:42:25 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #15088] openai: fix inconsistent created timestamp across streaming chunks #61710

New Issue
Open
opened 2026-04-29 16:44:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:44:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15088
Author: @Muszic
Created: 3/27/2026
Status: 🔄 Open

Base: main ← Head: fix-openai-streaming-timestamp

📝 Commits (1)

  • 077a50b openai: fix inconsistent created timestamp across streaming chunks

📊 Changes

3 files changed (+215 additions, -212 deletions)

View changed files

📝 middleware/openai.go (+7 -3)
📝 openai/openai.go (+71 -72)
📝 openai/openai_test.go (+137 -137)

📄 Description

What is the Bug?

Currently, the created field in every streaming chunk (ChatCompletionChunk) uses time.Now().Unix(), while the non-streaming final response uses r.CreatedAt.Unix().

This violates the OpenAI specification, which states that all streaming chunks for the same request must share the same created timestamp. With time.Now() called independently on every chunk via ToChunk, a long response produces chunks with sliding timestamps.

The Fix

  1. Added a createdAt int64 field to both ChatWriter and CompleteWriter structs in middleware/openai.go.
  2. Initialized it exactly once with time.Now().Unix() when the middleware sets up the writer.
  3. Passed this static timestamp down through ToChunks, ToChunk, and ToCompleteChunk in openai/openai.go to ensure absolute timestamp consistency across the entire stream.
  4. Updated existing tests in openai_test.go to pass a static timestamp.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15088 **Author:** [@Muszic](https://github.com/Muszic) **Created:** 3/27/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-openai-streaming-timestamp` --- ### 📝 Commits (1) - [`077a50b`](https://github.com/ollama/ollama/commit/077a50baa53553339fa1b545c74e08d88db90add) openai: fix inconsistent created timestamp across streaming chunks ### 📊 Changes **3 files changed** (+215 additions, -212 deletions) <details> <summary>View changed files</summary> 📝 `middleware/openai.go` (+7 -3) 📝 `openai/openai.go` (+71 -72) 📝 `openai/openai_test.go` (+137 -137) </details> ### 📄 Description ### What is the Bug? Currently, the `created` field in every streaming chunk (`ChatCompletionChunk`) uses `time.Now().Unix()`, while the non-streaming final response uses `r.CreatedAt.Unix()`. This violates the OpenAI specification, which states that all streaming chunks for the same request must share the same `created` timestamp. With `time.Now()` called independently on every chunk via `ToChunk`, a long response produces chunks with sliding timestamps. ### The Fix 1. Added a `createdAt` `int64` field to both `ChatWriter` and `CompleteWriter` structs in `middleware/openai.go`. 2. Initialized it exactly once with `time.Now().Unix()` when the middleware sets up the writer. 3. Passed this static timestamp down through `ToChunks`, `ToChunk`, and `ToCompleteChunk` in `openai/openai.go` to ensure absolute timestamp consistency across the entire stream. 4. Updated existing tests in `openai_test.go` to pass a static timestamp. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:44:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#61710
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?