github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14924] fix: correctly count CRLF line endings in modelfile parser #61619

New Issue
Open
opened 2026-04-29 16:41:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:41:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14924
Author: @Jah-yee
Created: 3/18/2026
Status: 🔄 Open

Base: main ← Head: fix/crlf-line-counting

📝 Commits (2)

  • c8fbaa9 fix(app): remove sidebar open animation on initial load
  • b0a68c1 fix: correctly count CRLF line endings in modelfile parser

📊 Changes

2 files changed (+17 additions, -5 deletions)

View changed files

📝 app/ui/app/src/components/layout/layout.tsx (+14 -4)
📝 parser/parser.go (+3 -1)

📄 Description

The parser was incorrectly counting Windows-style line endings (CRLF) as two separate lines, causing incorrect line numbers in error messages. This fix tracks the previous character and only increments the line counter when encountering a newline that is not part of a CRLF sequence.

Fixes #14901

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14924 **Author:** [@Jah-yee](https://github.com/Jah-yee) **Created:** 3/18/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/crlf-line-counting` --- ### 📝 Commits (2) - [`c8fbaa9`](https://github.com/ollama/ollama/commit/c8fbaa9e5be988741138b0eeda781df56e5181f4) fix(app): remove sidebar open animation on initial load - [`b0a68c1`](https://github.com/ollama/ollama/commit/b0a68c11dec1068174d9b6e8b6ce659300bdd5d0) fix: correctly count CRLF line endings in modelfile parser ### 📊 Changes **2 files changed** (+17 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/ui/app/src/components/layout/layout.tsx` (+14 -4) 📝 `parser/parser.go` (+3 -1) </details> ### 📄 Description The parser was incorrectly counting Windows-style line endings (CRLF) as two separate lines, causing incorrect line numbers in error messages. This fix tracks the previous character and only increments the line counter when encountering a newline that is not part of a CRLF sequence. Fixes #14901 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:41:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#61619
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?