github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14710] server: fix response body leak in upload retry loop #61499

New Issue
Open
opened 2026-04-29 16:35:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:35:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14710
Author: @gambletan
Created: 3/8/2026
Status: 🔄 Open

Base: main ← Head: fix/upload-response-body-leak

📝 Commits (1)

  • e706581 server: fix response body leak in upload retry loop

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/upload.go (+1 -1)

📄 Description

What

Fix a response body resource leak in blobUpload.Run().

Why

The defer resp.Body.Close() at line 210 is inside a for loop (the retry loop at line 199). In Go, defer is scoped to the enclosing function, not the loop iteration, so the response body is not closed until Run() returns. If retries occur, multiple response bodies accumulate without being closed, leaking HTTP connections.

Since this is a finalization PUT request with Content-Length: 0, the response body only needs to be drained and closed. Closing it immediately (without defer) is correct and prevents the leak.

Change

Replace defer resp.Body.Close() with resp.Body.Close() since the function breaks out of the loop immediately after.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14710 **Author:** [@gambletan](https://github.com/gambletan) **Created:** 3/8/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/upload-response-body-leak` --- ### 📝 Commits (1) - [`e706581`](https://github.com/ollama/ollama/commit/e706581f6f375abe282760031b4c97da1d50e9f1) server: fix response body leak in upload retry loop ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/upload.go` (+1 -1) </details> ### 📄 Description ## What Fix a response body resource leak in `blobUpload.Run()`. ## Why The `defer resp.Body.Close()` at line 210 is inside a `for` loop (the retry loop at line 199). In Go, `defer` is scoped to the enclosing function, not the loop iteration, so the response body is not closed until `Run()` returns. If retries occur, multiple response bodies accumulate without being closed, leaking HTTP connections. Since this is a finalization PUT request with `Content-Length: 0`, the response body only needs to be drained and closed. Closing it immediately (without `defer`) is correct and prevents the leak. ## Change Replace `defer resp.Body.Close()` with `resp.Body.Close()` since the function breaks out of the loop immediately after. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:35:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#61499
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?