github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14668] skills: add advanced lifecycle/safety features and test coverage #61472

New Issue
Open
opened 2026-04-29 16:33:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:33:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14668
Author: @googlarz
Created: 3/6/2026
Status: 🔄 Open

Base: main ← Head: codex/skills-core-tests

📝 Commits (4)

  • 777c297 skills: add CLI/chat runtime and lifecycle implementation
  • ecf6281 skills: narrow initial CLI surface to core commands
  • 610a129 skills: add advanced lifecycle and catalog command surface
  • 8a8dc15 skills: add coverage for lifecycle, policy, and audit behavior

📊 Changes

7 files changed (+4873 additions, -0 deletions)

View changed files

📝 cmd/cmd.go (+140 -0)
📝 cmd/interactive.go (+69 -0)
➕ cmd/skills_cli.go (+598 -0)
➕ cmd/skills_cli_test.go (+341 -0)
➕ skills/catalog.go (+184 -0)
➕ skills/skills.go (+2731 -0)
➕ skills/skills_test.go (+810 -0)

📄 Description

Summary

  • expand from MVP to include search/info/update/verify/uninstall/rollback/allow/revoke/logs command surface
  • add catalog search/filtering support and interactive /skilltrace
  • add focused coverage for lifecycle, permissions, rollback/update, catalog filtering, policy behavior, and audit rotation

Validation

  • GOCACHE=/tmp/go-build-cache GOMODCACHE=/tmp/go-mod-cache GOPATH=/tmp/go go test ./skills -count=1
  • GOCACHE=/tmp/go-build-cache GOMODCACHE=/tmp/go-mod-cache GOPATH=/tmp/go go test ./cmd -run "TestSkills" -count=1
  • GOCACHE=/tmp/go-build-cache GOMODCACHE=/tmp/go-mod-cache GOPATH=/tmp/go go test ./cmd -count=1

Notes

  • This is stack PR 2/3 for review order.
  • Review after #14667; commits here expand the MVP and add tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14668 **Author:** [@googlarz](https://github.com/googlarz) **Created:** 3/6/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/skills-core-tests` --- ### 📝 Commits (4) - [`777c297`](https://github.com/ollama/ollama/commit/777c29769e02e54f3fd367c8f9d15bf578ce0767) skills: add CLI/chat runtime and lifecycle implementation - [`ecf6281`](https://github.com/ollama/ollama/commit/ecf628123f431cfb62989faaed9013e9566dc978) skills: narrow initial CLI surface to core commands - [`610a129`](https://github.com/ollama/ollama/commit/610a129edb972b17e8b43a0293797ae4718fc5c8) skills: add advanced lifecycle and catalog command surface - [`8a8dc15`](https://github.com/ollama/ollama/commit/8a8dc15baec5c747808149437742666f0ac5621a) skills: add coverage for lifecycle, policy, and audit behavior ### 📊 Changes **7 files changed** (+4873 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/cmd.go` (+140 -0) 📝 `cmd/interactive.go` (+69 -0) ➕ `cmd/skills_cli.go` (+598 -0) ➕ `cmd/skills_cli_test.go` (+341 -0) ➕ `skills/catalog.go` (+184 -0) ➕ `skills/skills.go` (+2731 -0) ➕ `skills/skills_test.go` (+810 -0) </details> ### 📄 Description ## Summary - expand from MVP to include search/info/update/verify/uninstall/rollback/allow/revoke/logs command surface - add catalog search/filtering support and interactive `/skilltrace` - add focused coverage for lifecycle, permissions, rollback/update, catalog filtering, policy behavior, and audit rotation ## Validation - GOCACHE=/tmp/go-build-cache GOMODCACHE=/tmp/go-mod-cache GOPATH=/tmp/go go test ./skills -count=1 - GOCACHE=/tmp/go-build-cache GOMODCACHE=/tmp/go-mod-cache GOPATH=/tmp/go go test ./cmd -run "TestSkills" -count=1 - GOCACHE=/tmp/go-build-cache GOMODCACHE=/tmp/go-mod-cache GOPATH=/tmp/go go test ./cmd -count=1 ## Notes - This is stack PR 2/3 for review order. - Review after #14667; commits here expand the MVP and add tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:33:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#61472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?