github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14659] cmd/config: register verbose flag in LaunchCmd #61468

New Issue
Open
opened 2026-04-29 16:33:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 16:33:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14659
Author: @majiayu000
Created: 3/6/2026
Status: 🔄 Open

Base: main ← Head: fix/launch-verbose-flag

📝 Commits (1)

  • d2f5708 cmd/config: register verbose flag in LaunchCmd

📊 Changes

2 files changed (+6 additions, -0 deletions)

View changed files

📝 cmd/config/integrations.go (+1 -0)
📝 cmd/config/integrations_test.go (+5 -0)

📄 Description

Summary

  • Register the verbose flag on LaunchCmd so that the interactive chat flow (which reads and sets this flag) works correctly when launched via ollama launch

Problem

Running a model through ollama launch triggers: Error running model: flag accessed but not defined: verbose. The interactive chat code (generateInteractive / chat) accesses cmd.Flags().GetBool("verbose"), but LaunchCmd never registered that flag.

Test plan

  • Added verbose flag existence check to TestLaunchCmd/flags_exist
  • All existing cmd/config tests pass

Fixes #14654

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14659 **Author:** [@majiayu000](https://github.com/majiayu000) **Created:** 3/6/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/launch-verbose-flag` --- ### 📝 Commits (1) - [`d2f5708`](https://github.com/ollama/ollama/commit/d2f5708c80a73a156f481db98201f1504bea18c8) cmd/config: register verbose flag in LaunchCmd ### 📊 Changes **2 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `cmd/config/integrations.go` (+1 -0) 📝 `cmd/config/integrations_test.go` (+5 -0) </details> ### 📄 Description ## Summary - Register the `verbose` flag on `LaunchCmd` so that the interactive chat flow (which reads and sets this flag) works correctly when launched via `ollama launch` ## Problem Running a model through `ollama launch` triggers: `Error running model: flag accessed but not defined: verbose`. The interactive chat code (`generateInteractive` / `chat`) accesses `cmd.Flags().GetBool("verbose")`, but `LaunchCmd` never registered that flag. ## Test plan - Added `verbose` flag existence check to `TestLaunchCmd/flags_exist` - All existing `cmd/config` tests pass Fixes #14654 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 16:33:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#61468
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?