github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #12402] [MERGED] bugfix: restore the current runOptions if loading fails in the CLI #60510

New Issue
Closed
opened 2026-04-29 15:30:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 15:30:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12402
Author: @pdevine
Created: 9/24/2025
Status: ✅ Merged
Merged: 9/26/2025
Merged by: @pdevine

Base: main ← Head: pdevine/cli-loadcrash

📝 Commits (1)

  • 7bfbc71 bugfix: restore the current runOptions if loading fails in the CLI

📊 Changes

3 files changed (+338 additions, -1 deletions)

View changed files

📝 cmd/cmd.go (+45 -0)
📝 cmd/cmd_test.go (+284 -0)
📝 cmd/interactive.go (+9 -1)

📄 Description

There are two bugs when using /load <model> for a model that doesn't exist, namely:

  1. it will not restore the current model settings if the current model is a thinking model; and
  2. it will crash is the current model is a non-thinking model

This bug fix saves the current runOptions and then restores them if the model load doesn't happen. It also fixes the crash happening for non-thinking models.

Fixes #12351

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12402 **Author:** [@pdevine](https://github.com/pdevine) **Created:** 9/24/2025 **Status:** ✅ Merged **Merged:** 9/26/2025 **Merged by:** [@pdevine](https://github.com/pdevine) **Base:** `main` ← **Head:** `pdevine/cli-loadcrash` --- ### 📝 Commits (1) - [`7bfbc71`](https://github.com/ollama/ollama/commit/7bfbc71c5db574a2f92e7b2a7e9a80b40b111ec6) bugfix: restore the current runOptions if loading fails in the CLI ### 📊 Changes **3 files changed** (+338 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cmd/cmd.go` (+45 -0) 📝 `cmd/cmd_test.go` (+284 -0) 📝 `cmd/interactive.go` (+9 -1) </details> ### 📄 Description There are two bugs when using `/load <model>` for a model that doesn't exist, namely: 1. it will not restore the current model settings if the current model is a thinking model; and 2. it will crash is the current model is a non-thinking model This bug fix saves the current runOptions and then restores them if the model load doesn't happen. It also fixes the crash happening for non-thinking models. Fixes #12351 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 15:30:30 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#60510
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?