github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #12157] MacOS: exclude warning for home Applications dir #60420

New Issue
Open
opened 2026-04-29 15:23:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 15:23:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12157
Author: @jrschumacher
Created: 9/2/2025
Status: 🔄 Open

Base: main ← Head: support-local-app-dir

📝 Commits (10+)

📊 Changes

541 files changed (+343454 additions, -71924 deletions)

View changed files

📝 .github/workflows/release.yaml (+41 -137)
📝 .github/workflows/test.yaml (+12 -9)
📝 .golangci.yaml (+1 -1)
📝 CMakeLists.txt (+11 -4)
📝 CMakePresets.json (+5 -14)
📝 CONTRIBUTING.md (+2 -1)
📝 Dockerfile (+10 -18)
📝 Makefile.sync (+28 -16)
📝 README.md (+53 -26)
📝 api/client.go (+54 -4)
📝 api/client_test.go (+12 -3)
📝 api/types.go (+231 -45)
📝 api/types_test.go (+117 -1)
➕ api/types_typescript_test.go (+142 -0)
📝 app/lifecycle/logging.go (+2 -20)
➖ benchmark/server_benchmark_test.go (+0 -178)
📝 cmd/cmd.go (+360 -53)
📝 cmd/cmd_test.go (+8 -13)
📝 cmd/interactive.go (+64 -12)
📝 cmd/interactive_test.go (+38 -4)

...and 80 more files

📄 Description

When checking if the MacOS package is in the applications directory we
are not considering if they are in the user home directory ~/Applications. This is a
valid location for a MacOS application and critical when directories
like /Applications is governed by system policies.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12157 **Author:** [@jrschumacher](https://github.com/jrschumacher) **Created:** 9/2/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `support-local-app-dir` --- ### 📝 Commits (10+) - [`444ee71`](https://github.com/ollama/ollama/commit/444ee714a77e9ed7efbf398b455631c77596c5c6) chore: remove unused ZipReader type (#10621) - [`dbde1b6`](https://github.com/ollama/ollama/commit/dbde1b67fb8e0e5894cb0cf0940b32ed898ff8ac) lint: enable usetesting, disable tenv (#10594) - [`7f513a6`](https://github.com/ollama/ollama/commit/7f513a6d466d34306bc0b8972f191f295aba7e07) fix: stream accumulator exits early (#10593) - [`9733b4d`](https://github.com/ollama/ollama/commit/9733b4decc2f6f2a9843775e398f6ce7dff53c9f) cmd: strip single quotes from image page (#10636) - [`6944610`](https://github.com/ollama/ollama/commit/69446104a8c81c4ba4ef39e2348c39be1f9cc891) readme: add ojira to community integrations (#10648) - [`d9cf336`](https://github.com/ollama/ollama/commit/d9cf336adeb7a5cf51a55485133edf2e71e0f068) feat: add threshold to dump options (#10639) - [`6faf548`](https://github.com/ollama/ollama/commit/6faf548d3a7bbb90c247a5d90be0deb73b5802f7) envconfig: Remove no longer supported max vram var (#10623) - [`1791b68`](https://github.com/ollama/ollama/commit/1791b68cc20ab1dcb06d75be167203c18bbec9f6) llama: allocate grammar buffer based on schema length (#10649) - [`87ad1fe`](https://github.com/ollama/ollama/commit/87ad1fe2d2dea17fde7eaf411db15aa8017bf645) readme: add OllamaPlusPlus C++ library to community integrations (#10664) - [`d69f623`](https://github.com/ollama/ollama/commit/d69f623dd69339f3dfdb47039465231047200a23) readme: add UnityCodeLama to community integrations (#10665) ### 📊 Changes **541 files changed** (+343454 additions, -71924 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yaml` (+41 -137) 📝 `.github/workflows/test.yaml` (+12 -9) 📝 `.golangci.yaml` (+1 -1) 📝 `CMakeLists.txt` (+11 -4) 📝 `CMakePresets.json` (+5 -14) 📝 `CONTRIBUTING.md` (+2 -1) 📝 `Dockerfile` (+10 -18) 📝 `Makefile.sync` (+28 -16) 📝 `README.md` (+53 -26) 📝 `api/client.go` (+54 -4) 📝 `api/client_test.go` (+12 -3) 📝 `api/types.go` (+231 -45) 📝 `api/types_test.go` (+117 -1) ➕ `api/types_typescript_test.go` (+142 -0) 📝 `app/lifecycle/logging.go` (+2 -20) ➖ `benchmark/server_benchmark_test.go` (+0 -178) 📝 `cmd/cmd.go` (+360 -53) 📝 `cmd/cmd_test.go` (+8 -13) 📝 `cmd/interactive.go` (+64 -12) 📝 `cmd/interactive_test.go` (+38 -4) _...and 80 more files_ </details> ### 📄 Description When checking if the MacOS package is in the applications directory we are not considering if they are in the user home directory `~/Applications`. This is a valid location for a MacOS application and critical when directories like `/Applications` is governed by system policies. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 15:23:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#60420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?