[PR #10997] [MERGED] win: handle more than 2048 processes #60104

Closed
opened 2026-04-29 15:01:37 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10997
Author: @dhiltgen
Created: 6/6/2025
Status: Merged
Merged: 6/6/2025
Merged by: @dhiltgen

Base: mainHead: win_ps


📝 Commits (1)

  • 88a3359 win: handle more than 2048 processes

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 cmd/start_windows.go (+10 -1)

📄 Description

Fix an array out of bounds crash when trying to start the desktop app

>  ollama ps
panic: runtime error: slice bounds out of range [:2692] with capacity 2048

goroutine 1 [running]:
github.com/ollama/ollama/cmd.isProcRunning({0x7ff7575bc25a, 0xf})
        C:/a/ollama/ollama/cmd/start_windows.go:77 +0x398
github.com/ollama/ollama/cmd.startApp({0x7ff75777d210, 0x7ff7580d4920}, 0x40002a1d18)
        C:/a/ollama/ollama/cmd/start_windows.go:25 +0x48
github.com/ollama/ollama/cmd.checkServerHeartbeat(0x40000c6908, {0x7ff7575a975a?, 0x4?, 0x7ff7575a975e?})
        C:/a/ollama/ollama/cmd/cmd.go:1347 +0xf0
github.com/spf13/cobra.(*Command).execute(0x40000c6908, {0x7ff7580d4920, 0x0, 0x0})
        C:/Users/runneradmin/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:925 +0x5f0
github.com/spf13/cobra.(*Command).ExecuteC(0x4000029208)
        C:/Users/runneradmin/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068 +0x320
github.com/spf13/cobra.(*Command).Execute(...)
        C:/Users/runneradmin/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992
github.com/spf13/cobra.(*Command).ExecuteContext(...)
        C:/Users/runneradmin/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:985
main.main()
        C:/a/ollama/ollama/main.go:12 +0x54

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10997 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 6/6/2025 **Status:** ✅ Merged **Merged:** 6/6/2025 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `win_ps` --- ### 📝 Commits (1) - [`88a3359`](https://github.com/ollama/ollama/commit/88a3359475cdb2893180d4ea4257887540a308bd) win: handle more than 2048 processes ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cmd/start_windows.go` (+10 -1) </details> ### 📄 Description Fix an array out of bounds crash when trying to start the desktop app ``` > ollama ps panic: runtime error: slice bounds out of range [:2692] with capacity 2048 goroutine 1 [running]: github.com/ollama/ollama/cmd.isProcRunning({0x7ff7575bc25a, 0xf}) C:/a/ollama/ollama/cmd/start_windows.go:77 +0x398 github.com/ollama/ollama/cmd.startApp({0x7ff75777d210, 0x7ff7580d4920}, 0x40002a1d18) C:/a/ollama/ollama/cmd/start_windows.go:25 +0x48 github.com/ollama/ollama/cmd.checkServerHeartbeat(0x40000c6908, {0x7ff7575a975a?, 0x4?, 0x7ff7575a975e?}) C:/a/ollama/ollama/cmd/cmd.go:1347 +0xf0 github.com/spf13/cobra.(*Command).execute(0x40000c6908, {0x7ff7580d4920, 0x0, 0x0}) C:/Users/runneradmin/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:925 +0x5f0 github.com/spf13/cobra.(*Command).ExecuteC(0x4000029208) C:/Users/runneradmin/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:1068 +0x320 github.com/spf13/cobra.(*Command).Execute(...) C:/Users/runneradmin/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:992 github.com/spf13/cobra.(*Command).ExecuteContext(...) C:/Users/runneradmin/go/pkg/mod/github.com/spf13/cobra@v1.7.0/command.go:985 main.main() C:/a/ollama/ollama/main.go:12 +0x54 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 15:01:37 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#60104