[PR #6675] [CLOSED] Bugfix for #6656 (Fixed redirect check if direct URL is already Present) #58891

Closed
opened 2026-04-29 13:46:49 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/6675
Author: @Tobix99
Created: 9/6/2024
Status: Closed

Base: mainHead: main


📝 Commits (4)

  • f4a5b36 fixed return URL when status is ok
  • 47ebc1a added more redirect codes
  • 0faf383 Merge branch 'ollama:main' into main
  • 15545d8 Merge branch 'ollama:main' into main

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 server/download.go (+8 -2)

📄 Description

Sorry, this is a Bugfix for my old PR from yesterday. I hadn't tested it thoroughly yesterday and noticed another bug in the logic.

With this new logic it should return

  • the requestURL on Status OK
  • the Redirect URL on Status TemporaryRedirect
  • and an error on an unexpected status code

I've tested it now with a local registry and it pulls the image.

This PR should close #6308.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/6675 **Author:** [@Tobix99](https://github.com/Tobix99) **Created:** 9/6/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`f4a5b36`](https://github.com/ollama/ollama/commit/f4a5b36c32ce6992abced6effe06ce49f4347018) fixed return URL when status is ok - [`47ebc1a`](https://github.com/ollama/ollama/commit/47ebc1a29b968013b3738186adcfa884bd9d3265) added more redirect codes - [`0faf383`](https://github.com/ollama/ollama/commit/0faf383ba8a3b60cb6b9e5164361707dc41991aa) Merge branch 'ollama:main' into main - [`15545d8`](https://github.com/ollama/ollama/commit/15545d87a75aa0f7d1c70ff9632715a59e3a0466) Merge branch 'ollama:main' into main ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/download.go` (+8 -2) </details> ### 📄 Description Sorry, this is a Bugfix for my old PR from [yesterday](https://github.com/ollama/ollama/pull/6656#issue-2507674135). I hadn't tested it thoroughly yesterday and noticed another bug in the logic. With this new logic it should return - the requestURL on Status OK - the Redirect URL on Status TemporaryRedirect - and an error on an unexpected status code I've tested it now with a local registry and it pulls the image. This PR should close #6308. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 13:46:49 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#58891