github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-09 01:59:50 -05:00
Code Issues 14.6k Packages Projects Releases 122 Wiki Activity

[PR #5893] [MERGED] Fix Embed Test Flakes #58653

New Issue
Closed
opened 2026-04-29 13:33:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 13:33:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/5893
Author: @royjhan
Created: 7/23/2024
Status: ✅ Merged
Merged: 7/24/2024
Merged by: @royjhan

Base: main ← Head: royh-embed-test

📝 Commits (2)

📊 Changes

1 file changed (+54 additions, -5 deletions)

View changed files

📝 integration/embed_test.go (+54 -5)

📄 Description

different results on different taters
e.g.

=== RUN TestAllMiniLMEmbeddings
2024/07/23 17:05:36 INFO server connection host=tater21 port=55426
2024/07/23 17:05:36 INFO checking status of model model=all-minilm
2024/07/23 17:05:36 INFO model already present model=all-minilm
embed_test.go:42: expected 0.06642947345972061, got 0.0664294660091400
--- FAIL: TestAllMiniLMEmbeddings (0.31s)

also added a basic sanity check for /api/embeddings, which had no test before

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/5893 **Author:** [@royjhan](https://github.com/royjhan) **Created:** 7/23/2024 **Status:** ✅ Merged **Merged:** 7/24/2024 **Merged by:** [@royjhan](https://github.com/royjhan) **Base:** `main` ← **Head:** `royh-embed-test` --- ### 📝 Commits (2) - [`4c3fc65`](https://github.com/ollama/ollama/commit/4c3fc65d2b6b7f72e45c696aa60b760215a65ce8) float cmp - [`56b3cf8`](https://github.com/ollama/ollama/commit/56b3cf809458f8a9f4e0a693d5f41dc03f0ca331) increase tolerance ### 📊 Changes **1 file changed** (+54 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `integration/embed_test.go` (+54 -5) </details> ### 📄 Description different results on different taters e.g. === RUN TestAllMiniLMEmbeddings 2024/07/23 17:05:36 INFO server connection host=tater21 port=55426 2024/07/23 17:05:36 INFO checking status of model model=all-minilm 2024/07/23 17:05:36 INFO model already present model=all-minilm embed_test.go:42: expected 0.06642947345972061, got 0.0664294660091400 --- FAIL: TestAllMiniLMEmbeddings (0.31s) also added a basic sanity check for /api/embeddings, which had no test before --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 13:33:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#58653
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?