github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-05 23:53:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #3661] [MERGED] better checking for OLLAMA_HOST variable #57935

New Issue
Closed
opened 2026-04-29 12:43:43 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 12:43:43 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/3661
Author: @pdevine
Created: 4/15/2024
Status: ✅ Merged
Merged: 4/29/2024
Merged by: @pdevine

Base: main ← Head: pdevine/hostandport

📝 Commits (5)

📊 Changes

4 files changed (+83 additions, -15 deletions)

View changed files

📝 api/client.go (+35 -8)
📝 api/client_test.go (+43 -1)
📝 api/types.go (+1 -0)
📝 cmd/cmd.go (+4 -6)

📄 Description

This change adds better validation to the OLLAMA_HOST variable when used with ollama serve. It should work with both IPv4 and IPv6, and includes unit tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/3661 **Author:** [@pdevine](https://github.com/pdevine) **Created:** 4/15/2024 **Status:** ✅ Merged **Merged:** 4/29/2024 **Merged by:** [@pdevine](https://github.com/pdevine) **Base:** `main` ← **Head:** `pdevine/hostandport` --- ### 📝 Commits (5) - [`89c4f69`](https://github.com/ollama/ollama/commit/89c4f692af0ffeed816b0ed03d4a2aa1d97b65db) better checking for OLLAMA_HOST variable - [`6883262`](https://github.com/ollama/ollama/commit/6883262a72ce0a202cc5a8146fff4285c4d28770) comments - [`4fecd34`](https://github.com/ollama/ollama/commit/4fecd34bd5d6b08d8661caccf7a18879be5e48d9) add more tests + omit spaces/quotes - [`ef2bb3c`](https://github.com/ollama/ollama/commit/ef2bb3cb7b26c3ac3ec5ea6afbb9723bac8312fd) more comments - [`010b4aa`](https://github.com/ollama/ollama/commit/010b4aaeae88e6e092bc5c122745d4c636988219) still more comments ### 📊 Changes **4 files changed** (+83 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `api/client.go` (+35 -8) 📝 `api/client_test.go` (+43 -1) 📝 `api/types.go` (+1 -0) 📝 `cmd/cmd.go` (+4 -6) </details> ### 📄 Description This change adds better validation to the `OLLAMA_HOST` variable when used with `ollama serve`. It should work with both IPv4 and IPv6, and includes unit tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 12:43:43 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#57935
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?