[PR #3146] [MERGED] server: replace blob prefix separator from ':' to '-' #57778

Closed
opened 2026-04-29 12:29:58 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/3146
Author: @bmizerany
Created: 3/14/2024
Status: Merged
Merged: 3/15/2024
Merged by: @bmizerany

Base: mainHead: bmizerany/replacecolon2


📝 Commits (4)

  • 710b654 server: replace blog prefix separator from ':' to '-'
  • 516a584 revert invalid change to HasPrefix check
  • 57f8ba7 multi-file tests
  • 5d88ab9 add negative case

📊 Changes

6 files changed (+120 additions, -13 deletions)

View changed files

server/fixblobs.go (+26 -0)
server/fixblobs_test.go (+83 -0)
📝 server/images.go (+1 -3)
📝 server/layers.go (+1 -5)
📝 server/modelpath.go (+1 -5)
📝 server/routes.go (+8 -0)

📄 Description

This fixes issues with blob file names that contain ':' characters to be
9 rejected by file systems that do not support them.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/3146 **Author:** [@bmizerany](https://github.com/bmizerany) **Created:** 3/14/2024 **Status:** ✅ Merged **Merged:** 3/15/2024 **Merged by:** [@bmizerany](https://github.com/bmizerany) **Base:** `main` ← **Head:** `bmizerany/replacecolon2` --- ### 📝 Commits (4) - [`710b654`](https://github.com/ollama/ollama/commit/710b65431784dbce61abc74085967d94b140cbb3) server: replace blog prefix separator from ':' to '-' - [`516a584`](https://github.com/ollama/ollama/commit/516a584e240abd94ee73fab9b4f0f0ca284e3c7f) revert invalid change to HasPrefix check - [`57f8ba7`](https://github.com/ollama/ollama/commit/57f8ba7469eac02648498f6770cf94f11b4f6e0f) multi-file tests - [`5d88ab9`](https://github.com/ollama/ollama/commit/5d88ab97c696c84e917cd1347ebbf535d1a87022) add negative case ### 📊 Changes **6 files changed** (+120 additions, -13 deletions) <details> <summary>View changed files</summary> ➕ `server/fixblobs.go` (+26 -0) ➕ `server/fixblobs_test.go` (+83 -0) 📝 `server/images.go` (+1 -3) 📝 `server/layers.go` (+1 -5) 📝 `server/modelpath.go` (+1 -5) 📝 `server/routes.go` (+8 -0) </details> ### 📄 Description This fixes issues with blob file names that contain ':' characters to be 9 rejected by file systems that do not support them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 12:29:58 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#57778