github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #1129] [CLOSED] fix: parse ggml model types #57172

New Issue
Closed
opened 2026-04-29 11:45:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-29 11:45:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/1129
Author: @BruceMacD
Created: 11/14/2023
Status: ❌ Closed

Base: main ← Head: brucemacd/ggml_model_import

📝 Commits (1)

  • 5ac5af3 fix: parse ggml model types

📊 Changes

2 files changed (+32 additions, -27 deletions)

View changed files

📝 llm/ggml.go (+30 -20)
📝 llm/gguf.go (+2 -7)

📄 Description

I'm kind of surprised this didn't come up earlier, noticed this while importing a less common ggml model type. Model parsing was returning nil for uncommon types which results in a nil pointer dereference. Fix this by moving model parsing up a level and try to decode as a llama model in the default case.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/1129 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 11/14/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `brucemacd/ggml_model_import` --- ### 📝 Commits (1) - [`5ac5af3`](https://github.com/ollama/ollama/commit/5ac5af3edc50a7e2aaf8e20630e0c5c0f4a1aefa) fix: parse ggml model types ### 📊 Changes **2 files changed** (+32 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `llm/ggml.go` (+30 -20) 📝 `llm/gguf.go` (+2 -7) </details> ### 📄 Description I'm kind of surprised this didn't come up earlier, noticed this while importing a less common ggml model type. Model parsing was returning `nil` for uncommon types which results in a nil pointer dereference. Fix this by moving model parsing up a level and try to decode as a llama model in the default case. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 11:45:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#57172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?