github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[GH-ISSUE #10439] Granite 3.3: thinking does not work if using system prompt #53375

New Issue
Open
opened 2026-04-29 02:47:57 -05:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-04-29 02:47:57 -05:00
Owner
Copy Link

Originally created by @sebdotv on GitHub (Apr 28, 2025).
Original GitHub issue: https://github.com/ollama/ollama/issues/10439

What is the issue?

Thinking works unless there's a system prompt specified.

Note: httpie syntax

http POST localhost:11434/api/chat model=granite3.3:8b stream:=false \
  'messages[]:={"role": "control", "content": "thinking"}' \
  'messages[]:={"role": "user", "content": "hello"}'

response: <think>...</think> <response>...<response>, as expected

http POST localhost:11434/api/chat model=granite3.3:8b stream:=false \
  'messages[]:={"role": "system", "content": "You are a helpful AI agent."}' \
  'messages[]:={"role": "control", "content": "thinking"}' \
  'messages[]:={"role": "user", "content": "hello"}'

response: no <think> or <response>

Template version: 3da071a01bbe

According to logs, the thinking-specific part was not added to computed system prompt (expected: Respond to every user query in a comprehensive and detailed way. [...] Write your thoughts between <think></think> and write your response between <response></response> for each user query.)

Relevant log output

level=DEBUG source=routes.go:1523 msg="chat request" images=0 prompt="<|start_of_role|>system<|end_of_role|>You are a helpful AI agent.<|end_of_text|>\n<|start_of_role|>user<|end_of_role|>hello<|end_of_text|>\n<|start_of_role|>assistant<|end_of_role|>"

OS

Linux

GPU

Nvidia

CPU

No response

Ollama version

0.6.6

Originally created by @sebdotv on GitHub (Apr 28, 2025). Original GitHub issue: https://github.com/ollama/ollama/issues/10439 ### What is the issue? Thinking works unless there's a system prompt specified. Note: [httpie](https://httpie.io/) syntax ```shell http POST localhost:11434/api/chat model=granite3.3:8b stream:=false \ 'messages[]:={"role": "control", "content": "thinking"}' \ 'messages[]:={"role": "user", "content": "hello"}' ``` response: `<think>...</think> <response>...<response>`, as expected ```shell http POST localhost:11434/api/chat model=granite3.3:8b stream:=false \ 'messages[]:={"role": "system", "content": "You are a helpful AI agent."}' \ 'messages[]:={"role": "control", "content": "thinking"}' \ 'messages[]:={"role": "user", "content": "hello"}' ``` response: no `<think>` or `<response>` Template version: `3da071a01bbe` According to logs, the thinking-specific part was not added to computed system prompt (expected: `Respond to every user query in a comprehensive and detailed way. [...] Write your thoughts between <think></think> and write your response between <response></response> for each user query.`) ### Relevant log output ``` level=DEBUG source=routes.go:1523 msg="chat request" images=0 prompt="<|start_of_role|>system<|end_of_role|>You are a helpful AI agent.<|end_of_text|>\n<|start_of_role|>user<|end_of_role|>hello<|end_of_text|>\n<|start_of_role|>assistant<|end_of_role|>" ``` ### OS Linux ### GPU Nvidia ### CPU _No response_ ### Ollama version 0.6.6
GiteaMirror added the bug label 2026-04-29 02:47:57 -05:00
GiteaMirror commented 2026-04-29 02:48:03 -05:00
Author
Owner
Copy Link

@sebdotv commented on GitHub (Apr 28, 2025):

I believe this is because the thinking part (line 98 of https://ollama.com/library/granite3.3/blobs/3da071a01bbe) is only added if the system prompt is empty (line 70):

{{- if eq $system "" }}

Instead, it should be appended to the end of the system prompt (even if not empty).

<!-- gh-comment-id:2835596666 --> @sebdotv commented on GitHub (Apr 28, 2025): I believe this is because the thinking part (line 98 of https://ollama.com/library/granite3.3/blobs/3da071a01bbe) is only added if the system prompt is empty (line 70): ``` {{- if eq $system "" }} ``` Instead, it should be appended to the end of the system prompt (even if not empty).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#53375
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?