github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[GH-ISSUE #8796] BUG: Deserialization for JSON Schema is incorrect #52223

New Issue
Closed
opened 2026-04-28 22:33:39 -05:00 by GiteaMirror · 3 comments
GiteaMirror commented 2026-04-28 22:33:39 -05:00
Owner
Copy Link

Originally created by @ssddOnTop on GitHub (Feb 3, 2025).
Original GitHub issue: https://github.com/ollama/ollama/issues/8796

Originally assigned to: @ParthSareen on GitHub.

What is the issue?

I was trying to use /v1 route where req/response is OpenAI compatible

In ad22ace439/api/types.go (L170)

Type is of type string, however, according to https://datatracker.ietf.org/doc/html/draft-handrews-json-schema-02 it could be a string or an array of strings

OS

No response

GPU

No response

CPU

No response

Ollama version

0.5.7

Originally created by @ssddOnTop on GitHub (Feb 3, 2025). Original GitHub issue: https://github.com/ollama/ollama/issues/8796 Originally assigned to: @ParthSareen on GitHub. ### What is the issue? I was trying to use `/v1` route where req/response is [OpenAI compatible](https://github.com/ollama/ollama/blob/main/docs/openai.md) In https://github.com/ollama/ollama/blob/ad22ace439eb3fab7230134e56bb6276a78347e4/api/types.go#L170 `Type` is of type string, however, according to https://datatracker.ietf.org/doc/html/draft-handrews-json-schema-02 it could be a string or an array of strings ### OS _No response_ ### GPU _No response_ ### CPU _No response_ ### Ollama version 0.5.7
GiteaMirror added the bug label 2026-04-28 22:33:39 -05:00
GiteaMirror commented 2026-04-28 22:33:42 -05:00
Author
Owner
Copy Link

@ParthSareen commented on GitHub (Feb 7, 2025):

Was this blocking for use with a specific schema? Could you provide the schema you were using.

<!-- gh-comment-id:2644147137 --> @ParthSareen commented on GitHub (Feb 7, 2025): Was this blocking for use with a specific schema? Could you provide the schema you were using.
GiteaMirror commented 2026-04-28 22:33:43 -05:00
Author
Owner
Copy Link

@ssddOnTop commented on GitHub (Feb 7, 2025):

I was using schemars crate to generate JSON schema for structs.

However if I had an Optional field in a struct like:

struct Foo {
  bar: Option<String>,
}

the crate generated a schema in which the Parameters' Type field is an array ["string", "null"] which is compatible with OpenRouter and handrews-json-schema-02 but Ollama only supports string for now.

<!-- gh-comment-id:2644321322 --> @ssddOnTop commented on GitHub (Feb 7, 2025): I was using [schemars](https://github.com/GREsau/schemars) crate to generate JSON schema for structs. However if I had an Optional field in a struct like: ```rs struct Foo { bar: Option<String>, } ``` the crate generated a schema in which the `Parameters'` `Type` field is an array `["string", "null"]` which is compatible with [OpenRouter](https://openrouter.ai/) and [handrews-json-schema-02](https://datatracker.ietf.org/doc/html/draft-handrews-json-schema-02) but Ollama only supports string for now.
GiteaMirror commented 2026-04-28 22:33:44 -05:00
Author
Owner
Copy Link

@ParthSareen commented on GitHub (Feb 7, 2025):

@ssddOnTop From my understanding that's not an official spec. Optional values tend to be defined with an anyOf for JSON. If you do find docs differing this please let me know.

<!-- gh-comment-id:2644336135 --> @ParthSareen commented on GitHub (Feb 7, 2025): @ssddOnTop From my understanding that's not an official spec. Optional values tend to be defined with an `anyOf` for JSON. If you do find docs differing this please let me know.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#52223
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?