github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[GH-ISSUE #6377] Full(er) JSON Schema support for tool calling #50517

New Issue
Closed
opened 2026-04-28 16:09:17 -05:00 by GiteaMirror · 4 comments
GiteaMirror commented 2026-04-28 16:09:17 -05:00
Owner
Copy Link

Originally created by @mitar on GitHub (Aug 15, 2024).
Original GitHub issue: https://github.com/ollama/ollama/issues/6377

Currently parameters in tool definition is a very limited subset of a JSON Schema. This makes it non-compatible with OpenAI (https://github.com/ollama/ollama/issues/6155) and it general it makes it really hard to use it because you cannot pass JSON Schema as parameters but have to manually map to the API structure tool definition expects. Good enough if you are manually making a tool definition, but hard if you have automatic process to generate JSON Schema (for example, I use https://github.com/invopop/jsonschema Go package to generate JSON Schema from Go struct automatically, which works great with other API providers like OpenAI).

So I would suggest that API is relaxed to get embedded JSON Schema and not just fixed structure it currently allows.

Originally created by @mitar on GitHub (Aug 15, 2024). Original GitHub issue: https://github.com/ollama/ollama/issues/6377 Currently `parameters` in tool definition is a very limited subset of a JSON Schema. This makes it non-compatible with OpenAI (https://github.com/ollama/ollama/issues/6155) and it general it makes it really hard to use it because you cannot pass JSON Schema as `parameters` but have to manually map to the API structure tool definition expects. Good enough if you are manually making a tool definition, but hard if you have automatic process to generate JSON Schema (for example, I use https://github.com/invopop/jsonschema Go package to generate JSON Schema from Go struct automatically, which works great with other API providers like OpenAI). So I would suggest that API is relaxed to get embedded JSON Schema and not just fixed structure it currently allows.
GiteaMirror added the feature requestapi labels 2026-04-28 16:09:17 -05:00
GiteaMirror commented 2026-04-28 16:09:29 -05:00
Author
Owner
Copy Link

@mitar commented on GitHub (Aug 15, 2024):

Also the Parameters struct from ToolFunction should be an exported symbol in Go API so that it is possible to unmarshal JSON directly into that struct.

<!-- gh-comment-id:2292214934 --> @mitar commented on GitHub (Aug 15, 2024): Also the `Parameters` struct from `ToolFunction` should be an exported symbol in Go API so that it is possible to unmarshal JSON directly into that struct.
GiteaMirror commented 2026-04-28 16:09:30 -05:00
Author
Owner
Copy Link

@adela185 commented on GitHub (Aug 30, 2024):

I would also like to bring attention to this addition. It seems like tool calling jsons only go two levels deep at the point that the prompt is generated. Any extra nested properties or keys beyond are truncated. This limits ability for complex tooll calls.

<!-- gh-comment-id:2321151502 --> @adela185 commented on GitHub (Aug 30, 2024): I would also like to bring attention to this addition. It seems like tool calling jsons only go two levels deep at the point that the prompt is generated. Any extra nested properties or keys beyond are truncated. This limits ability for complex tooll calls.
GiteaMirror commented 2026-04-28 16:09:31 -05:00
Author
Owner
Copy Link

@jonigl commented on GitHub (Jul 16, 2025):

Hi there! I ran into the same issue and wanted to share my findings. I opened this issue, where I describe what I discovered and propose a possible solution.

To address the problem, I’ve also submitted two PRs to refactor the related behavior:

Would love any feedback or thoughts on it thanks!

<!-- gh-comment-id:3081596959 --> @jonigl commented on GitHub (Jul 16, 2025): Hi there! I ran into the same issue and wanted to share my findings. I opened [this issue](https://github.com/ollama/ollama/issues/11444), where I describe what I discovered and propose a possible solution. To address the problem, I’ve also submitted two PRs to refactor the related behavior: * [PR #11448 (ollama/ollama)](https://github.com/ollama/ollama/pull/11448) * [PR #542 (ollama/ollama-python)](https://github.com/ollama/ollama-python/pull/542)python/pull/542) Would love any feedback or thoughts on it thanks!
GiteaMirror commented 2026-04-28 16:09:33 -05:00
Author
Owner
Copy Link

@mitar commented on GitHub (Oct 7, 2025):

It looks like ToolFunctionParameters is now available.

<!-- gh-comment-id:3378676520 --> @mitar commented on GitHub (Oct 7, 2025): It looks like `ToolFunctionParameters` is now available.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label api feature request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#50517
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?