github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[GH-ISSUE #675] api improvements #46814

New Issue
Closed
opened 2026-04-28 00:20:34 -05:00 by GiteaMirror · 7 comments
GiteaMirror commented 2026-04-28 00:20:34 -05:00
Owner
Copy Link

Originally created by @jtoy on GitHub (Oct 2, 2023).
Original GitHub issue: https://github.com/ollama/ollama/issues/675

its a stream of objects that are separated with a newline. often times new lines are returned in the response, so that breaks just splitting on new lines.
I think the split should be on something else.
Also it seems like there should be an api endpoint that just returns the whole response in a string.

thoughts?

Originally created by @jtoy on GitHub (Oct 2, 2023). Original GitHub issue: https://github.com/ollama/ollama/issues/675 its a stream of objects that are separated with a newline. often times new lines are returned in the response, so that breaks just splitting on new lines. I think the split should be on something else. Also it seems like there should be an api endpoint that just returns the whole response in a string. thoughts?
GiteaMirror commented 2026-04-28 00:20:37 -05:00
Author
Owner
Copy Link

@technovangelist commented on GitHub (Oct 2, 2023):

If using JS, sometimes fetch will grab multiple json objects at once if there are more than one available. Your code should split the string received by '\n' to ensure its dealing with a single response to parse. This is common in other streaming apis as well.

<!-- gh-comment-id:1743662978 --> @technovangelist commented on GitHub (Oct 2, 2023): If using JS, sometimes fetch will grab multiple json objects at once if there are more than one available. Your code should split the string received by '\n' to ensure its dealing with a single response to parse. This is common in other streaming apis as well.
GiteaMirror commented 2026-04-28 00:20:39 -05:00
Author
Owner
Copy Link

@jtoy commented on GitHub (Oct 2, 2023):

the problem is newlines in the responses

<!-- gh-comment-id:1743908625 --> @jtoy commented on GitHub (Oct 2, 2023): the problem is newlines in the responses
GiteaMirror commented 2026-04-28 00:20:43 -05:00
Author
Owner
Copy Link

@technovangelist commented on GitHub (Oct 2, 2023):

perhaps you can give an example of what you are referring to.

<!-- gh-comment-id:1743911954 --> @technovangelist commented on GitHub (Oct 2, 2023): perhaps you can give an example of what you are referring to.
GiteaMirror commented 2026-04-28 00:20:45 -05:00
Author
Owner
Copy Link

@technovangelist commented on GitHub (Oct 3, 2023):

Do you have an example of the problem you are seeing and what you think it should be?

<!-- gh-comment-id:1744975423 --> @technovangelist commented on GitHub (Oct 3, 2023): Do you have an example of the problem you are seeing and what you think it should be?
GiteaMirror commented 2026-04-28 00:20:46 -05:00
Author
Owner
Copy Link

@reustle commented on GitHub (Oct 4, 2023):

Also it seems like there should be an api endpoint that just returns the whole response in a string.

For this, fortunately there is a recent PR for this that seems like it will be merged soon https://github.com/jmorganca/ollama/pull/639

<!-- gh-comment-id:1746176558 --> @reustle commented on GitHub (Oct 4, 2023): > Also it seems like there should be an api endpoint that just returns the whole response in a string. For this, fortunately there is a recent PR for this that seems like it will be merged soon https://github.com/jmorganca/ollama/pull/639
GiteaMirror commented 2026-04-28 00:20:46 -05:00
Author
Owner
Copy Link

@technovangelist commented on GitHub (Oct 5, 2023):

Haven't heard back from you. If you have an example, please reopen but for now I'll close this.

<!-- gh-comment-id:1749282102 --> @technovangelist commented on GitHub (Oct 5, 2023): Haven't heard back from you. If you have an example, please reopen but for now I'll close this.
GiteaMirror commented 2026-04-28 00:20:47 -05:00
Author
Owner
Copy Link

@mccainz commented on GitHub (Jan 10, 2024):

Also it seems like there should be an api endpoint that just returns the whole response in a string.

For this, fortunately there is a recent PR for this that seems like it will be merged soon #639

"stream" : false works perfectly in this regard.

<!-- gh-comment-id:1884830590 --> @mccainz commented on GitHub (Jan 10, 2024): > > Also it seems like there should be an api endpoint that just returns the whole response in a string. > > For this, fortunately there is a recent PR for this that seems like it will be merged soon #639 `"stream" : false` works perfectly in this regard.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#46814
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?