github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-07-16 21:25:46 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #15789] [MERGED] openai: map responses reasoning effort to think #46507

New Issue
Closed
opened 2026-04-25 01:55:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 01:55:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15789
Author: @ParthSareen
Created: 4/24/2026
Status: ✅ Merged
Merged: 4/24/2026
Merged by: @ParthSareen

Base: main ← Head: parth-map-responses-thinking

📝 Commits (1)

  • 2c3f76d openai: map responses reasoning effort to think

📊 Changes

2 files changed (+93 additions, -0 deletions)

View changed files

📝 openai/responses.go (+13 -0)
📝 openai/responses_test.go (+80 -0)

📄 Description

Summary

  • Map OpenAI Responses API reasoning.effort into api.ChatRequest.Think
  • Preserve explicit "max" reasoning for renderers that need it
  • Return a validation error for unsupported Responses reasoning effort values
  • Add table coverage for unset, low, medium, high, max, none, and invalid effort

Tests

  • go test ./openai
  • go test ./api ./openai ./cmd ./server

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15789 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 4/24/2026 **Status:** ✅ Merged **Merged:** 4/24/2026 **Merged by:** [@ParthSareen](https://github.com/ParthSareen) **Base:** `main` ← **Head:** `parth-map-responses-thinking` --- ### 📝 Commits (1) - [`2c3f76d`](https://github.com/ollama/ollama/commit/2c3f76d00b43b9dd5c7d15081bd36f1f4d3b8a92) openai: map responses reasoning effort to think ### 📊 Changes **2 files changed** (+93 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `openai/responses.go` (+13 -0) 📝 `openai/responses_test.go` (+80 -0) </details> ### 📄 Description ## Summary - Map OpenAI Responses API `reasoning.effort` into `api.ChatRequest.Think` - Preserve explicit `"max"` reasoning for renderers that need it - Return a validation error for unsupported Responses reasoning effort values - Add table coverage for unset, `low`, `medium`, `high`, `max`, `none`, and invalid effort ## Tests - `go test ./openai` - `go test ./api ./openai ./cmd ./server` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 01:55:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#46507
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?