github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15593] [MERGED] launch: always list cloud recommendations first #46472

New Issue
Closed
opened 2026-04-25 01:53:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 01:53:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15593
Author: @hoyyeva
Created: 4/14/2026
Status: ✅ Merged
Merged: 4/15/2026
Merged by: @hoyyeva

Base: main ← Head: hoyyeva/cloud-models-first-always

📝 Commits (1)

  • c463512 launch: always list cloud recommendations first

📊 Changes

2 files changed (+9 additions, -16 deletions)

View changed files

📝 cmd/launch/integrations_test.go (+9 -8)
📝 cmd/launch/models.go (+0 -8)

📄 Description

Summary
ollama launch was demoting cloud recommendations to the bottom of the model picker when the user had local models installed but no cloud models. The order now stays consistent — cloud recommendations first — regardless of installed inventory. The only time cloud models are hidden from the picker is when cloud is disabled on the server, which is already handled upstream in loadSelectableModels via filterCloudItems.

Change

  • Remove the onlyLocal branch in buildModelList's sort so cloud recommendations always sort before local recommendations.
  • Update the two tests that pinned the old "cloud at bottom when only-local" behavior.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15593 **Author:** [@hoyyeva](https://github.com/hoyyeva) **Created:** 4/14/2026 **Status:** ✅ Merged **Merged:** 4/15/2026 **Merged by:** [@hoyyeva](https://github.com/hoyyeva) **Base:** `main` ← **Head:** `hoyyeva/cloud-models-first-always` --- ### 📝 Commits (1) - [`c463512`](https://github.com/ollama/ollama/commit/c463512da010f20aee5d98d8774f3370d8062c29) launch: always list cloud recommendations first ### 📊 Changes **2 files changed** (+9 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `cmd/launch/integrations_test.go` (+9 -8) 📝 `cmd/launch/models.go` (+0 -8) </details> ### 📄 Description **Summary** `ollama launch` was demoting cloud recommendations to the bottom of the model picker when the user had local models installed but no cloud models. The order now stays consistent — cloud recommendations first — regardless of installed inventory. The only time cloud models are hidden from the picker is when cloud is disabled on the server, which is already handled upstream in `loadSelectableModels` via `filterCloudItems`. **Change** - Remove the `onlyLocal` branch in `buildModelList`'s sort so cloud recommendations always sort before local recommendations. - Update the two tests that pinned the old "cloud at bottom when only-local" behavior. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 01:53:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#46472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?