github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15089] middleware: improve ID entropy for OpenAI-compatible response IDs #46262

New Issue
Open
opened 2026-04-25 01:45:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 01:45:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15089
Author: @Muszic
Created: 3/27/2026
Status: 🔄 Open

Base: main ← Head: fix-openai-id-collisions

📝 Commits (1)

  • 19bdc89 middleware: improve ID entropy for OpenAI-compatible response IDs

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 middleware/openai.go (+4 -4)

📄 Description

What is the Bug?

Every OpenAI-compatible chat and completion request generates a unique ID. However, the IDs are currently generated using rand.Intn(999) and rand.Intn(999999), which gives a severely limited number of possible values. On any moderately busy server, concurrent requests will routinely collide on the same ID.

Additionally, OpenAI uses high-entropy globally unique identifiers. Ollama currently produces very short IDs like chatcmpl-42 or resp_7.

The Fix

Replaced rand.Intn(999) and rand.Intn(999999) with rand.Int63() and formatted the output as a hex string (%x) in the ChatMiddleware, CompletionsMiddleware, and ResponsesMiddleware.

This vastly improves the entropy (providing ~9.2 quintillion possible values) and produces more authentic-looking IDs (e.g., chatcmpl-7fffffffffffffff) without requiring any new external dependencies or impacting performance.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15089 **Author:** [@Muszic](https://github.com/Muszic) **Created:** 3/27/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-openai-id-collisions` --- ### 📝 Commits (1) - [`19bdc89`](https://github.com/ollama/ollama/commit/19bdc8916f426b47d3b15f9a5e59933a747b70d8) middleware: improve ID entropy for OpenAI-compatible response IDs ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `middleware/openai.go` (+4 -4) </details> ### 📄 Description ### What is the Bug? Every OpenAI-compatible chat and completion request generates a unique ID. However, the IDs are currently generated using `rand.Intn(999)` and `rand.Intn(999999)`, which gives a severely limited number of possible values. On any moderately busy server, concurrent requests will routinely collide on the same ID. Additionally, OpenAI uses high-entropy globally unique identifiers. Ollama currently produces very short IDs like `chatcmpl-42` or `resp_7`. ### The Fix Replaced `rand.Intn(999)` and `rand.Intn(999999)` with `rand.Int63()` and formatted the output as a hex string (`%x`) in the `ChatMiddleware`, `CompletionsMiddleware`, and `ResponsesMiddleware`. This vastly improves the entropy (providing ~9.2 quintillion possible values) and produces more authentic-looking IDs (e.g., `chatcmpl-7fffffffffffffff`) without requiring any new external dependencies or impacting performance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 01:45:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#46262
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?