github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14842] fix: preserve decimal precision in HumanBytes for values >= 10 #46119

New Issue
Open
opened 2026-04-25 01:38:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 01:38:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14842
Author: @LincolnBurrows2017
Created: 3/14/2026
Status: 🔄 Open

Base: main ← Head: fix-human-bytes-decimal

📝 Commits (2)

  • c48be94 fix: correct typo ViewSeperator -> ViewSeparator in deepseekocr model
  • a09e4e8 fix: preserve decimal precision in HumanBytes for values >= 10

📊 Changes

3 files changed (+9 additions, -5 deletions)

View changed files

📝 format/bytes.go (+2 -2)
📝 format/bytes_test.go (+5 -0)
📝 model/models/deepseekocr/model.go (+2 -3)

📄 Description

Summary

In format/bytes.go, the HumanBytes function had a logic error:

Problem: When value >= 10 has decimals (like 15.5 TB), it incorrectly displays as "15 TB", losing decimal precision.

Fix: Changed the order of checks to check decimals first:

// Before (wrong)
switch {
case value >= 10:
    return fmt.Sprintf("%d %s", int(value), unit)
case value != math.Trunc(value):
    return fmt.Sprintf("%.1f %s", value, unit)
}

// After (correct)
switch {
case value != math.Trunc(value):
    return fmt.Sprintf("%.1f %s", value, unit)
case value >= 10:
    return fmt.Sprintf("%d %s", int(value), unit)
}

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14842 **Author:** [@LincolnBurrows2017](https://github.com/LincolnBurrows2017) **Created:** 3/14/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-human-bytes-decimal` --- ### 📝 Commits (2) - [`c48be94`](https://github.com/ollama/ollama/commit/c48be94ac71ffe697cb92e7ca4b8eecd6d93826b) fix: correct typo ViewSeperator -> ViewSeparator in deepseekocr model - [`a09e4e8`](https://github.com/ollama/ollama/commit/a09e4e88df885360421f6fafa839b284b690d1eb) fix: preserve decimal precision in HumanBytes for values >= 10 ### 📊 Changes **3 files changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `format/bytes.go` (+2 -2) 📝 `format/bytes_test.go` (+5 -0) 📝 `model/models/deepseekocr/model.go` (+2 -3) </details> ### 📄 Description ## Summary In `format/bytes.go`, the `HumanBytes` function had a logic error: **Problem:** When value >= 10 has decimals (like 15.5 TB), it incorrectly displays as "15 TB", losing decimal precision. **Fix:** Changed the order of checks to check decimals first: ```go // Before (wrong) switch { case value >= 10: return fmt.Sprintf("%d %s", int(value), unit) case value != math.Trunc(value): return fmt.Sprintf("%.1f %s", value, unit) } // After (correct) switch { case value != math.Trunc(value): return fmt.Sprintf("%.1f %s", value, unit) case value >= 10: return fmt.Sprintf("%d %s", int(value), unit) } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 01:38:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#46119
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?