[PR #13486] [MERGED] fix: qwen2.5 vl rope #45480

Closed
opened 2026-04-25 01:10:53 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13486
Author: @mxyng
Created: 12/15/2025
Status: Merged
Merged: 12/16/2025
Merged by: @mxyng

Base: mainHead: mxyng/fix-qwen25vl


📝 Commits (3)

📊 Changes

6 files changed (+198 additions, -219 deletions)

View changed files

📝 ml/backend/ggml/ggml.go (+6 -3)
📝 ml/nn/rope/options.go (+7 -0)
📝 model/models/qwen25vl/model.go (+76 -30)
📝 model/models/qwen25vl/model_text.go (+12 -30)
📝 model/models/qwen25vl/model_vision.go (+91 -144)
📝 model/models/qwen25vl/process_image.go (+6 -12)

📄 Description

this change fixes a few bugs with qwen2.5 vl, mostly around positional embeddings which affect bounding boxes. this updates the model to use fast rope for both vision and text models. it also adjusts the max pixels supported by the model to accommodate 1440x900 inputs


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13486 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 12/15/2025 **Status:** ✅ Merged **Merged:** 12/16/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/fix-qwen25vl` --- ### 📝 Commits (3) - [`f9c3e38`](https://github.com/ollama/ollama/commit/f9c3e385f560e7bcffeac209c15f4a4a512ea496) qwen25vl: bump max pixels - [`5fb395f`](https://github.com/ollama/ollama/commit/5fb395f9f9acff85aa44943078097c90e6fa15bc) qwen25vl: mrope - [`d47f63e`](https://github.com/ollama/ollama/commit/d47f63e425650f87b5737972f68ef723a7d5a2bc) qwen25vl: vision rope ### 📊 Changes **6 files changed** (+198 additions, -219 deletions) <details> <summary>View changed files</summary> 📝 `ml/backend/ggml/ggml.go` (+6 -3) 📝 `ml/nn/rope/options.go` (+7 -0) 📝 `model/models/qwen25vl/model.go` (+76 -30) 📝 `model/models/qwen25vl/model_text.go` (+12 -30) 📝 `model/models/qwen25vl/model_vision.go` (+91 -144) 📝 `model/models/qwen25vl/process_image.go` (+6 -12) </details> ### 📄 Description this change fixes a few bugs with qwen2.5 vl, mostly around positional embeddings which affect bounding boxes. this updates the model to use fast rope for both vision and text models. it also adjusts the max pixels supported by the model to accommodate 1440x900 inputs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 01:10:53 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#45480