github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-05 23:53:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #11074] Allow to refer local type definitions on a root level of ToolFunction schema #44678

New Issue
Open
opened 2026-04-25 00:17:45 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 00:17:45 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/11074
Author: @kudla
Created: 6/15/2025
Status: 🔄 Open

Base: main ← Head: main

📝 Commits (2)

  • 967e621 allow tool function schema to refer local type definitions
  • 9628764 make ToolFunction.Properties.required as well optional in favor of declaration option

📊 Changes

1 file changed (+5 additions, -3 deletions)

View changed files

📝 api/types.go (+5 -3)

📄 Description

As it is allowed to define json schema definitions for a ToolFunction structure still it is not possible to refer this declarations from the Properties declarations their selfs.

So this trying to fix this.

  • Verified the tests scoped for api/types*.go only. Not affected.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/11074 **Author:** [@kudla](https://github.com/kudla) **Created:** 6/15/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`967e621`](https://github.com/ollama/ollama/commit/967e62162d608b866795ce0429123121353527b3) allow tool function schema to refer local type definitions - [`9628764`](https://github.com/ollama/ollama/commit/9628764bff53386c565d51e3e4e497869d454415) make ToolFunction.Properties.required as well optional in favor of declaration option ### 📊 Changes **1 file changed** (+5 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+5 -3) </details> ### 📄 Description As it is allowed to define json schema definitions for a `ToolFunction` structure still it is not possible to refer this declarations from the `Properties` declarations their selfs. So this trying to fix this. * [x] Verified the tests scoped for `api/types*.go` only. Not affected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 00:17:45 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#44678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?