github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #11056] [CLOSED] Fix The download flag #44672

New Issue
Closed
opened 2026-04-25 00:17:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 00:17:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/11056
Author: @sk15er
Created: 6/12/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

  • c3738da The logic now ensures that a model is only flagged or reported as "downloaded" after all blobs are fully downloaded and verified, not just after pulling the manifest. This prevents fake download counts from manifest-only requests.

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 server/images.go (+11 -0)

📄 Description

The logic now ensures that a model is only flagged or reported as "downloaded" after all blobs are fully downloaded and verified, not just after pulling the manifest. This prevents fake download counts from manifest-only requests.

A placeholder function reportModelDownload(name string) is called at the end of a successful PullModel. You can implement your actual reporting/statistics logic there.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/11056 **Author:** [@sk15er](https://github.com/sk15er) **Created:** 6/12/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`c3738da`](https://github.com/ollama/ollama/commit/c3738da5dac4166e6ee3924ee1e45cba4f32425a) The logic now ensures that a model is only flagged or reported as "downloaded" after all blobs are fully downloaded and verified, not just after pulling the manifest. This prevents fake download counts from manifest-only requests. ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/images.go` (+11 -0) </details> ### 📄 Description The logic now ensures that a model is only flagged or reported as "downloaded" after all blobs are fully downloaded and verified, not just after pulling the manifest. This prevents fake download counts from manifest-only requests. A placeholder function reportModelDownload(name string) is called at the end of a successful PullModel. You can implement your actual reporting/statistics logic there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 00:17:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#44672
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?