github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #9347] [MERGED] server/internal: replace model delete API with new registry handler #44169

New Issue
Closed
opened 2026-04-24 23:42:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-24 23:42:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/9347
Author: @bmizerany
Created: 2/25/2025
Status: ✅ Merged
Merged: 2/27/2025
Merged by: @bmizerany

Base: main ← Head: bmizerany/ollama-go-delete

📝 Commits (1)

  • e671b88 server/internal: replace model delete API with new registry handler.

📊 Changes

16 files changed (+705 additions, -90 deletions)

View changed files

📝 go.mod (+7 -7)
📝 go.sum (+14 -14)
📝 server/internal/cache/blob/cache.go (+19 -9)
📝 server/internal/cache/blob/cache_test.go (+5 -2)
📝 server/internal/cache/blob/casecheck_test.go (+1 -1)
📝 server/internal/client/ollama/registry.go (+77 -17)
📝 server/internal/client/ollama/registry_test.go (+95 -25)
📝 server/internal/cmd/opp/opp.go (+2 -2)
➕ server/internal/registry/server.go (+215 -0)
➕ server/internal/registry/server_test.go (+168 -0)
➕ server/internal/registry/testdata/models/blobs/sha256-a4e5e156ddec27e286f75328784d7106b60a4eb1d246e950a001a3f944fbda99 (+0 -0)
➕ server/internal/registry/testdata/models/blobs/sha256-ecfb1acfca9c76444d622fcdc3840217bd502124a9d3687d438c19b3cb9c3cb1 (+1 -0)
➕ server/internal/registry/testdata/models/manifests/registry.ollama.ai/library/smol/latest (+1 -0)
📝 server/internal/testutil/testutil.go (+28 -0)
📝 server/routes.go (+32 -7)
📝 server/routes_test.go (+40 -6)

📄 Description

This commit introduces a new API implementation for handling
interactions with the registry and the local model cache. The new API is
located in server/internal/registry. The package name is "registry" and
should be considered temporary; it is hidden and not bleeding outside of
the server package. As the commits roll in, we'll start consuming more
of the API and then let reverse osmosis take effect, at which point it
will surface closer to the root level packages as much as needed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/9347 **Author:** [@bmizerany](https://github.com/bmizerany) **Created:** 2/25/2025 **Status:** ✅ Merged **Merged:** 2/27/2025 **Merged by:** [@bmizerany](https://github.com/bmizerany) **Base:** `main` ← **Head:** `bmizerany/ollama-go-delete` --- ### 📝 Commits (1) - [`e671b88`](https://github.com/ollama/ollama/commit/e671b88d7a357598beb5889bab55b911481858f3) server/internal: replace model delete API with new registry handler. ### 📊 Changes **16 files changed** (+705 additions, -90 deletions) <details> <summary>View changed files</summary> 📝 `go.mod` (+7 -7) 📝 `go.sum` (+14 -14) 📝 `server/internal/cache/blob/cache.go` (+19 -9) 📝 `server/internal/cache/blob/cache_test.go` (+5 -2) 📝 `server/internal/cache/blob/casecheck_test.go` (+1 -1) 📝 `server/internal/client/ollama/registry.go` (+77 -17) 📝 `server/internal/client/ollama/registry_test.go` (+95 -25) 📝 `server/internal/cmd/opp/opp.go` (+2 -2) ➕ `server/internal/registry/server.go` (+215 -0) ➕ `server/internal/registry/server_test.go` (+168 -0) ➕ `server/internal/registry/testdata/models/blobs/sha256-a4e5e156ddec27e286f75328784d7106b60a4eb1d246e950a001a3f944fbda99` (+0 -0) ➕ `server/internal/registry/testdata/models/blobs/sha256-ecfb1acfca9c76444d622fcdc3840217bd502124a9d3687d438c19b3cb9c3cb1` (+1 -0) ➕ `server/internal/registry/testdata/models/manifests/registry.ollama.ai/library/smol/latest` (+1 -0) 📝 `server/internal/testutil/testutil.go` (+28 -0) 📝 `server/routes.go` (+32 -7) 📝 `server/routes_test.go` (+40 -6) </details> ### 📄 Description This commit introduces a new API implementation for handling interactions with the registry and the local model cache. The new API is located in server/internal/registry. The package name is "registry" and should be considered temporary; it is hidden and not bleeding outside of the server package. As the commits roll in, we'll start consuming more of the API and then let reverse osmosis take effect, at which point it will surface closer to the root level packages as much as needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-24 23:42:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#44169
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?