[PR #8941] [MERGED] ci: use windows-2022 to sign and bundle #44071

Closed
opened 2026-04-24 23:36:29 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8941
Author: @mxyng
Created: 2/8/2025
Status: Merged
Merged: 2/8/2025
Merged by: @jmorganca

Base: mainHead: mxyng/release


📝 Commits (1)

  • 9d97443 ci: use windows-2022 to sign and bundle

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 .github/workflows/release.yaml (+1 -1)
📝 scripts/build_windows.ps1 (+3 -0)

📄 Description

ollama requires vcruntime140_1.dll which isn't found on 2019. previously the job used the windows runner (2019) but it explicitly installs 2022 to build the app. since the sign job doesn't actually build anything, it can use the windows-2022 runner instead.

resolves #8936


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8941 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 2/8/2025 **Status:** ✅ Merged **Merged:** 2/8/2025 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `main` ← **Head:** `mxyng/release` --- ### 📝 Commits (1) - [`9d97443`](https://github.com/ollama/ollama/commit/9d974437fe2fc8d89353deb5a0b64e23f6241eb1) ci: use windows-2022 to sign and bundle ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yaml` (+1 -1) 📝 `scripts/build_windows.ps1` (+3 -0) </details> ### 📄 Description ollama requires `vcruntime140_1.dll` which isn't found on 2019. previously the job used the windows runner (2019) but it explicitly installs 2022 to build the app. since the sign job doesn't actually build anything, it can use the windows-2022 runner instead. resolves #8936 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-24 23:36:29 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#44071