[PR #7428] [MERGED] Soften windows clang requirement #43665

Closed
opened 2026-04-24 23:16:04 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/7428
Author: @dhiltgen
Created: 10/30/2024
Status: Merged
Merged: 10/30/2024
Merged by: @dhiltgen

Base: mainHead: compiler_info


📝 Commits (1)

  • d2ec289 Soften windows clang requirement

📊 Changes

6 files changed (+30 additions, -7 deletions)

View changed files

📝 .github/workflows/release.yaml (+4 -0)
📝 .github/workflows/test.yaml (+3 -0)
📝 docs/development.md (+1 -1)
📝 llama/llama.go (+21 -1)
📝 llama/make/common-defs.make (+0 -4)
📝 llama/runner/runner.go (+1 -1)

📄 Description

This will no longer error if built with regular gcc on windows. To help triage issues that may come in related to different compilers, the runner now reports the compiler used by cgo.

Example runner output when compiled with GCC

time=2024-10-30T11:29:49.863-07:00 level=INFO source=runner.go:877 msg=system info="AVX = 1 | AVX_VNNI = 0 | AVX2 = 0 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | AVX512_BF16 = 0 | FMA = 0 | NEON = 0 | SVE = 0 | ARM_FMA = 0 | F16C = 0 | FP16_VA = 0 | RISCV_VECT = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | MATMUL_INT8 = 0 | LLAMAFILE = 1 | cgo(gcc)" threads=16

and with clang:

time=2024-10-30T11:33:00.866-07:00 level=INFO source=runner.go:877 msg=system info="AVX = 1 | AVX_VNNI = 0 | AVX2 = 0 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | AVX512_BF16 = 0 | FMA = 0 | NEON = 0 | SVE = 0 | ARM_FMA = 0 | F16C = 0 | FP16_VA = 0 | RISCV_VECT = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | MATMUL_INT8 = 0 | LLAMAFILE = 1 | cgo(clang)" threads=16

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/7428 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 10/30/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `compiler_info` --- ### 📝 Commits (1) - [`d2ec289`](https://github.com/ollama/ollama/commit/d2ec289ac78b9ef63bfa137e3ee3bb79ff5bb322) Soften windows clang requirement ### 📊 Changes **6 files changed** (+30 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yaml` (+4 -0) 📝 `.github/workflows/test.yaml` (+3 -0) 📝 `docs/development.md` (+1 -1) 📝 `llama/llama.go` (+21 -1) 📝 `llama/make/common-defs.make` (+0 -4) 📝 `llama/runner/runner.go` (+1 -1) </details> ### 📄 Description This will no longer error if built with regular gcc on windows. To help triage issues that may come in related to different compilers, the runner now reports the compiler used by cgo. Example runner output when compiled with GCC ``` time=2024-10-30T11:29:49.863-07:00 level=INFO source=runner.go:877 msg=system info="AVX = 1 | AVX_VNNI = 0 | AVX2 = 0 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | AVX512_BF16 = 0 | FMA = 0 | NEON = 0 | SVE = 0 | ARM_FMA = 0 | F16C = 0 | FP16_VA = 0 | RISCV_VECT = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | MATMUL_INT8 = 0 | LLAMAFILE = 1 | cgo(gcc)" threads=16 ``` and with clang: ``` time=2024-10-30T11:33:00.866-07:00 level=INFO source=runner.go:877 msg=system info="AVX = 1 | AVX_VNNI = 0 | AVX2 = 0 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | AVX512_BF16 = 0 | FMA = 0 | NEON = 0 | SVE = 0 | ARM_FMA = 0 | F16C = 0 | FP16_VA = 0 | RISCV_VECT = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | MATMUL_INT8 = 0 | LLAMAFILE = 1 | cgo(clang)" threads=16 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-24 23:16:04 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#43665