[PR #3008] [MERGED] Finish unwinding idempotent payload logic #42280

Closed
opened 2026-04-24 22:03:51 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/3008
Author: @dhiltgen
Created: 3/8/2024
Status: Merged
Merged: 3/9/2024
Merged by: @dhiltgen

Base: mainHead: no_more_idempotent


📝 Commits (1)

  • 4a5c9b8 Finish unwinding idempotent payload logic

📊 Changes

6 files changed (+71 additions, -87 deletions)

View changed files

📝 docs/linux.md (+5 -0)
📝 gpu/amd_linux.go (+13 -21)
📝 gpu/amd_windows.go (+7 -17)
📝 gpu/assets.go (+25 -22)
📝 llm/payload_common.go (+20 -27)
📝 server/routes.go (+1 -0)

📄 Description

The recent ROCm change partially removed idempotent payloads, but the ggml-metal.metal file for mac was still idempotent. This finishes switching to always extract the payloads, and now that idempotentcy is gone, the version directory is no longer useful.

Tested on mac, linux, and windows.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/3008 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 3/8/2024 **Status:** ✅ Merged **Merged:** 3/9/2024 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `no_more_idempotent` --- ### 📝 Commits (1) - [`4a5c9b8`](https://github.com/ollama/ollama/commit/4a5c9b80350d5f430451568177da16fbe7baefe1) Finish unwinding idempotent payload logic ### 📊 Changes **6 files changed** (+71 additions, -87 deletions) <details> <summary>View changed files</summary> 📝 `docs/linux.md` (+5 -0) 📝 `gpu/amd_linux.go` (+13 -21) 📝 `gpu/amd_windows.go` (+7 -17) 📝 `gpu/assets.go` (+25 -22) 📝 `llm/payload_common.go` (+20 -27) 📝 `server/routes.go` (+1 -0) </details> ### 📄 Description The recent ROCm change partially removed idempotent payloads, but the ggml-metal.metal file for mac was still idempotent. This finishes switching to always extract the payloads, and now that idempotentcy is gone, the version directory is no longer useful. Tested on mac, linux, and windows. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-24 22:03:51 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#42280