github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #1774] [MERGED] fix: pull either original model or from model on create #41914

New Issue
Closed
opened 2026-04-24 21:43:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-24 21:43:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/1774
Author: @BruceMacD
Created: 1/3/2024
Status: ✅ Merged
Merged: 1/4/2024
Merged by: @BruceMacD

Base: main ← Head: brucemacd/create-ggml-pull

📝 Commits (2)

  • 2ae9e2c pull either original model or from model on create
  • bb3e32b Update images.go

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 server/images.go (+8 -2)

📄 Description

I created a bug here when accounting for the "pull parent model" case when pull gguf models on deprecated ggml models. In the case of a Modelfile like this:

FROM orca-mini
SYSTEM "you are mario"

where orca-mini is a ggml library model there is no ParentModel and the model itself should be pulled.

This handles both:

FROM orca-mini
SYSTEM "you are mario"

and a child:

FROM mario
PARAMETER temperature 0

correctly and will pull the root model for both cases.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/1774 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 1/3/2024 **Status:** ✅ Merged **Merged:** 1/4/2024 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/create-ggml-pull` --- ### 📝 Commits (2) - [`2ae9e2c`](https://github.com/ollama/ollama/commit/2ae9e2c2df08db4f654513839a2ae34fe61646f3) pull either original model or from model on create - [`bb3e32b`](https://github.com/ollama/ollama/commit/bb3e32bf2998d6aeaa32c575c02554471e67a238) Update images.go ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `server/images.go` (+8 -2) </details> ### 📄 Description I created a bug here when accounting for the "pull parent model" case when pull gguf models on deprecated ggml models. In the case of a Modelfile like this: ``` FROM orca-mini SYSTEM "you are mario" ``` where orca-mini is a `ggml` library model there is no `ParentModel` and the model itself should be pulled. This handles both: ``` FROM orca-mini SYSTEM "you are mario" ``` and a child: ``` FROM mario PARAMETER temperature 0 ``` correctly and will pull the root model for both cases. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-24 21:43:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#41914
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?