github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 08:02:14 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15712] [MERGED] cmd: populate model capabilities in launchInteractiveModel #41147

New Issue
Closed
opened 2026-04-23 01:52:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 01:52:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15712
Author: @mverrilli
Created: 4/19/2026
Status: ✅ Merged
Merged: 4/21/2026
Merged by: @hoyyeva

Base: main ← Head: fix/issue-15711-tui-multimodal-opts

📝 Commits (1)

  • c1dde4a cmd: populate model capabilities in launchInteractiveModel

📊 Changes

1 file changed (+55 additions, -2 deletions)

View changed files

📝 cmd/cmd.go (+55 -2)

📄 Description

Summary

  • launchInteractiveModel (the TUI path, added in #14609) was missing the client.Show() capability-detection block that RunHandler uses
  • This left opts.MultiModal always false in the TUI path, so image/audio file paths were always treated as unknown commands rather than loaded as multimodal attachments
  • Mirrors the Show() call, pull-on-404 fallback, cloud auth handling, and MultiModal/Think population from RunHandler into launchInteractiveModel

Fixes #15711

Test plan

  • go test ./cmd/... passes (1055 tests across 7 packages)
  • Manual: ollama serve + TUI — drag or type an image path into chat with a vision model; confirm it loads instead of printing "Unknown command"
  • Manual: non-vision model in TUI — image path still shows "Unknown command" (correct behavior)
  • Cloud model (model:cloud) in TUI — auth error handling preserved

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15712 **Author:** [@mverrilli](https://github.com/mverrilli) **Created:** 4/19/2026 **Status:** ✅ Merged **Merged:** 4/21/2026 **Merged by:** [@hoyyeva](https://github.com/hoyyeva) **Base:** `main` ← **Head:** `fix/issue-15711-tui-multimodal-opts` --- ### 📝 Commits (1) - [`c1dde4a`](https://github.com/ollama/ollama/commit/c1dde4a1e73aa332b985b0fae4f0d6c7f958bd69) cmd: populate model capabilities in launchInteractiveModel ### 📊 Changes **1 file changed** (+55 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/cmd.go` (+55 -2) </details> ### 📄 Description ## Summary - `launchInteractiveModel` (the TUI path, added in #14609) was missing the `client.Show()` capability-detection block that `RunHandler` uses - This left `opts.MultiModal` always `false` in the TUI path, so image/audio file paths were always treated as unknown commands rather than loaded as multimodal attachments - Mirrors the `Show()` call, pull-on-404 fallback, cloud auth handling, and `MultiModal`/`Think` population from `RunHandler` into `launchInteractiveModel` Fixes #15711 ## Test plan - [x] `go test ./cmd/...` passes (1055 tests across 7 packages) - [x] Manual: `ollama serve` + TUI — drag or type an image path into chat with a vision model; confirm it loads instead of printing "Unknown command" - [ ] Manual: non-vision model in TUI — image path still shows "Unknown command" (correct behavior) - [ ] Cloud model (`model:cloud`) in TUI — auth error handling preserved --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 01:52:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#41147
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?