github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15612] [MERGED] gemma4: render differently based on model size #41104

New Issue
Closed
opened 2026-04-23 01:50:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 01:50:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15612
Author: @drifkin
Created: 4/15/2026
Status: ✅ Merged
Merged: 4/16/2026
Merged by: @drifkin

Base: main ← Head: drifkin/gemma4-split-templates

📝 Commits (2)

  • e585ecd gemma4: render differently based on model size
  • 9e3618d make empty block conditional

📊 Changes

11 files changed (+406 additions, -16 deletions)

View changed files

📝 model/renderers/gemma4.go (+5 -1)
📝 model/renderers/gemma4_reference_test.go (+72 -11)
📝 model/renderers/renderer.go (+3 -1)
📝 server/create.go (+1 -1)
➕ server/gemma4_test.go (+78 -0)
📝 server/images.go (+1 -1)
📝 server/images_test.go (+33 -0)
📝 server/prompt.go (+2 -1)
📝 server/prompt_test.go (+48 -0)
➕ server/renderer_resolution.go (+110 -0)
📝 server/routes_create_test.go (+53 -0)

📄 Description

Following up on #15560, this change now has e2b/e4b render differently from 26b/31b.

For backwards compatibility, we take the existing renderer name gemma4 and make it do dynamic resolution based on the model name/size, but the intended use is for the models to be republished with the renderer variant specified explicitly: gemma4-small or gemma4-large.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15612 **Author:** [@drifkin](https://github.com/drifkin) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 4/16/2026 **Merged by:** [@drifkin](https://github.com/drifkin) **Base:** `main` ← **Head:** `drifkin/gemma4-split-templates` --- ### 📝 Commits (2) - [`e585ecd`](https://github.com/ollama/ollama/commit/e585ecd11f5e90f8b02d224122430049c0d56d8e) gemma4: render differently based on model size - [`9e3618d`](https://github.com/ollama/ollama/commit/9e3618d663e39e1cbddf5181be657d94cc1a8e52) make empty block conditional ### 📊 Changes **11 files changed** (+406 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `model/renderers/gemma4.go` (+5 -1) 📝 `model/renderers/gemma4_reference_test.go` (+72 -11) 📝 `model/renderers/renderer.go` (+3 -1) 📝 `server/create.go` (+1 -1) ➕ `server/gemma4_test.go` (+78 -0) 📝 `server/images.go` (+1 -1) 📝 `server/images_test.go` (+33 -0) 📝 `server/prompt.go` (+2 -1) 📝 `server/prompt_test.go` (+48 -0) ➕ `server/renderer_resolution.go` (+110 -0) 📝 `server/routes_create_test.go` (+53 -0) </details> ### 📄 Description Following up on #15560, this change now has e2b/e4b render differently from 26b/31b. For backwards compatibility, we take the existing renderer name `gemma4` and make it do dynamic resolution based on the model name/size, but the intended use is for the models to be republished with the renderer variant specified explicitly: `gemma4-small` or `gemma4-large`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 01:50:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#41104
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?