github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15030] [CLOSED] fix: close sqlite connection on app shutdown to prevent memory leak #40849

New Issue
Closed
opened 2026-04-23 01:38:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 01:38:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15030
Author: @BillionClaw
Created: 3/24/2026
Status: ❌ Closed

Base: main ← Head: clawoss/fix/sqlite-memory-leak-15021

📝 Commits (1)

  • 1579a21 fix: close sqlite connection on app shutdown to prevent memory leak

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 app/cmd/app/app.go (+4 -0)

📄 Description

When the Ollama desktop app shuts down, the sqlite database connection was never closed, causing WAL journal files and deleted data pages to not be reclaimed, leading to db.sqlite file size bloat on Windows (ollama/ollama#15021). This fix adds appStore.Close() to the shutdown sequence after the ollama server goroutine exits, ensuring WAL checkpoint runs and the connection is properly closed.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15030 **Author:** [@BillionClaw](https://github.com/BillionClaw) **Created:** 3/24/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `clawoss/fix/sqlite-memory-leak-15021` --- ### 📝 Commits (1) - [`1579a21`](https://github.com/ollama/ollama/commit/1579a21117d92fe2c0aaf3d1819a25643da2975b) fix: close sqlite connection on app shutdown to prevent memory leak ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/cmd/app/app.go` (+4 -0) </details> ### 📄 Description When the Ollama desktop app shuts down, the sqlite database connection was never closed, causing WAL journal files and deleted data pages to not be reclaimed, leading to db.sqlite file size bloat on Windows (ollama/ollama#15021). This fix adds appStore.Close() to the shutdown sequence after the ollama server goroutine exits, ensuring WAL checkpoint runs and the connection is properly closed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 01:38:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#40849
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?