github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14725] [CLOSED] fix: potential file descriptor leak in ListHandler #40681

New Issue
Closed
opened 2026-04-23 01:32:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 01:32:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14725
Author: @sushilibdev
Created: 3/9/2026
Status: ❌ Closed

Base: main ← Head: fix-listhandler-resource-leak

📄 Description

While investigating issue #14723, I noticed that ListHandler in server/routes.go uses defer f.Close() inside a loop. This can lead to a "too many open files" error or hanging when a user has many models, as the files aren't closed until the entire handler returns.

This PR wraps the manifest opening logic in a closure to ensure file descriptors are closed immediately after each iteration.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14725 **Author:** [@sushilibdev](https://github.com/sushilibdev) **Created:** 3/9/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-listhandler-resource-leak` --- ### 📄 Description While investigating issue #14723, I noticed that ListHandler in server/routes.go uses defer f.Close() inside a loop. This can lead to a "too many open files" error or hanging when a user has many models, as the files aren't closed until the entire handler returns. This PR wraps the manifest opening logic in a closure to ensure file descriptors are closed immediately after each iteration. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 01:32:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#40681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?