github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14565] [CLOSED] server: add model name validation and alias resolution to EmbedHandler #40598

New Issue
Closed
opened 2026-04-23 01:27:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 01:27:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14565
Author: @umut-polat
Created: 3/2/2026
Status: ❌ Closed

Base: main ← Head: fix/embed-handler-model-validation

📝 Commits (1)

  • c714c9b server: add model name validation and alias resolution to EmbedHandler

📊 Changes

1 file changed (+14 additions, -1 deletions)

View changed files

📝 server/routes.go (+14 -1)

📄 Description

EmbedHandler was missing two steps that both GenerateHandler and ChatHandler perform:

  1. Model name validation (name.IsValid() check) — an empty or invalid model name went straight to getExistingName, producing a confusing "model not found" error instead of the expected "model is required".

  2. Alias resolution (resolveAlias) — model aliases were silently ignored for /api/embed requests while working correctly for /api/generate and /api/chat.

This aligns EmbedHandler's validation flow with the other handlers.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14565 **Author:** [@umut-polat](https://github.com/umut-polat) **Created:** 3/2/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/embed-handler-model-validation` --- ### 📝 Commits (1) - [`c714c9b`](https://github.com/ollama/ollama/commit/c714c9b34eefa4c05532e11fc28cffee57bbf00e) server: add model name validation and alias resolution to EmbedHandler ### 📊 Changes **1 file changed** (+14 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+14 -1) </details> ### 📄 Description EmbedHandler was missing two steps that both GenerateHandler and ChatHandler perform: 1. **Model name validation** (`name.IsValid()` check) — an empty or invalid model name went straight to `getExistingName`, producing a confusing "model not found" error instead of the expected "model is required". 2. **Alias resolution** (`resolveAlias`) — model aliases were silently ignored for `/api/embed` requests while working correctly for `/api/generate` and `/api/chat`. This aligns EmbedHandler's validation flow with the other handlers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 01:27:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#40598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?