[PR #13138] [MERGED] win: exit instead of abort #39962

Closed
opened 2026-04-23 00:58:14 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13138
Author: @dhiltgen
Created: 11/18/2025
Status: Merged
Merged: 11/19/2025
Merged by: @dhiltgen

Base: mainHead: win_disco_fast_fail


📝 Commits (1)

  • c41b32f win: exit instead of abort

📊 Changes

2 files changed (+34 additions, -1 deletions)

View changed files

llama/patches/0036-win-exit-instead-of-abort.patch (+28 -0)
📝 ml/backend/ggml/ggml/src/ggml.c (+6 -1)

📄 Description

Calling abort on windows may trigger the C++ runtime to attempt a debugger attach, which causes the crashed runners to hang instead of exit, leading to a timeout instead of a fast failure during discovery.

Fixes #12264

Ref: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/abort?view=msvc-170


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13138 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/19/2025 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `win_disco_fast_fail` --- ### 📝 Commits (1) - [`c41b32f`](https://github.com/ollama/ollama/commit/c41b32fa35555a5de1c4dc436af55145fff8f4f2) win: exit instead of abort ### 📊 Changes **2 files changed** (+34 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `llama/patches/0036-win-exit-instead-of-abort.patch` (+28 -0) 📝 `ml/backend/ggml/ggml/src/ggml.c` (+6 -1) </details> ### 📄 Description Calling abort on windows may trigger the C++ runtime to attempt a debugger attach, which causes the crashed runners to hang instead of exit, leading to a timeout instead of a fast failure during discovery. Fixes #12264 Ref: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/abort?view=msvc-170 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 00:58:14 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#39962