[PR #13120] [MERGED] app/cmd: restrict ollama:// URL scheme to supported paths #39952

Closed
opened 2026-04-23 00:57:42 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13120
Author: @hoyyeva
Created: 11/17/2025
Status: Merged
Merged: 11/18/2025
Merged by: @hoyyeva

Base: mainHead: hoyyeva/urlscheme-fixes


📝 Commits (1)

  • 2ed0a55 app/cmd: restrict ollama:// URL scheme to supported paths

📊 Changes

2 files changed (+13 additions, -20 deletions)

View changed files

📝 app/cmd/app/app.go (+11 -18)
📝 app/cmd/app/app_windows.go (+2 -2)

📄 Description

This PR refactors the ollama:// URL scheme handler to explicitly support only the URL patterns that are actually used in practice. This makes the code simpler and more maintainable.

Updated parseURLScheme() to support the two external URL patterns currently in use:

  • ollama:// - Opens the application
  • ollama://connect - OAuth authentication flow

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13120 **Author:** [@hoyyeva](https://github.com/hoyyeva) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/18/2025 **Merged by:** [@hoyyeva](https://github.com/hoyyeva) **Base:** `main` ← **Head:** `hoyyeva/urlscheme-fixes` --- ### 📝 Commits (1) - [`2ed0a55`](https://github.com/ollama/ollama/commit/2ed0a55ddd53541616dacc3c23ded0ec3b5d0875) app/cmd: restrict ollama:// URL scheme to supported paths ### 📊 Changes **2 files changed** (+13 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `app/cmd/app/app.go` (+11 -18) 📝 `app/cmd/app/app_windows.go` (+2 -2) </details> ### 📄 Description This PR refactors the `ollama://` URL scheme handler to explicitly support only the URL patterns that are actually used in practice. This makes the code simpler and more maintainable. Updated `parseURLScheme()` to support the two external URL patterns currently in use: - `ollama://` - Opens the application - `ollama://connect` - OAuth authentication flow --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 00:57:42 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#39952