github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #12413] [MERGED] feat: Handle the case where a tool call sends "arguments" or "parameters" as a serialized json string #39689

New Issue
Closed
opened 2026-04-23 00:40:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 00:40:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12413
Author: @gabe-l-hart
Created: 9/25/2025
Status: ✅ Merged
Merged: 9/25/2025
Merged by: @jmorganca

Base: main ← Head: StringToolCallArgs

📝 Commits (2)

  • ab04798 feat: Handle the case where a tool call sends "arguments" or "parameters" as a serialized json string
  • 370edba test: Add unit test cases for stringified arguments and parameters

📊 Changes

2 files changed (+28 additions, -0 deletions)

View changed files

📝 tools/tools.go (+12 -0)
📝 tools/tools_test.go (+16 -0)

📄 Description

Description

Some models will return their tool calls with the arguments represented as a serialized json object (a string) rather than a nested object. This PR adds support for this case by attempting to parse a string under "arguments" or "parameters" as an object and using that as the arguments for the tool call.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12413 **Author:** [@gabe-l-hart](https://github.com/gabe-l-hart) **Created:** 9/25/2025 **Status:** ✅ Merged **Merged:** 9/25/2025 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `main` ← **Head:** `StringToolCallArgs` --- ### 📝 Commits (2) - [`ab04798`](https://github.com/ollama/ollama/commit/ab04798b353184c6bfd5b4070c25e70a2211d26e) feat: Handle the case where a tool call sends "arguments" or "parameters" as a serialized json string - [`370edba`](https://github.com/ollama/ollama/commit/370edba4d86d90b7ce8c12f0ff20575dbae06d68) test: Add unit test cases for stringified arguments and parameters ### 📊 Changes **2 files changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `tools/tools.go` (+12 -0) 📝 `tools/tools_test.go` (+16 -0) </details> ### 📄 Description ## Description Some models will return their tool calls with the arguments represented as a serialized json object (a string) rather than a nested object. This PR adds support for this case by attempting to parse a string under `"arguments"` or `"parameters"` as an object and using that as the arguments for the tool call. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 00:40:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#39689
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?