github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #10382] [MERGED] fs: generic ggml.array #39098

New Issue
Closed
opened 2026-04-22 23:44:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-22 23:44:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10382
Author: @mxyng
Created: 4/23/2025
Status: ✅ Merged
Merged: 4/25/2025
Merged by: @mxyng

Base: main ← Head: mxyng/generic-array

📝 Commits (9)

📊 Changes

21 files changed (+204 additions, -164 deletions)

View changed files

📝 convert/convert_test.go (+2 -3)
📝 fs/config.go (+1 -1)
📝 fs/ggml/ggml.go (+24 -30)
📝 fs/ggml/ggml_test.go (+59 -0)
📝 fs/ggml/gguf.go (+92 -103)
📝 llm/memory.go (+1 -1)
📝 model/models/gemma2/model.go (+1 -1)
📝 model/models/gemma3/model.go (+1 -1)
📝 model/models/gemma3/model_text.go (+1 -1)
📝 model/models/llama/model.go (+1 -1)
📝 model/models/mistral3/model_text.go (+1 -1)
📝 model/models/mllama/model.go (+1 -1)
📝 model/models/mllama/model_text.go (+4 -4)
📝 model/models/mllama/model_vision.go (+4 -4)
📝 model/process_text.go (+1 -1)
📝 model/process_text_spm_test.go (+3 -3)
📝 model/process_text_test.go (+1 -1)
📝 sample/samplers_test.go (+1 -2)
📝 server/create.go (+3 -3)
📝 server/images.go (+1 -1)

...and 1 more files

📄 Description

this updates ggml.array to use generics which makes it easier to use and avoids type asserting the array values

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10382 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 4/23/2025 **Status:** ✅ Merged **Merged:** 4/25/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/generic-array` --- ### 📝 Commits (9) - [`c16dd1f`](https://github.com/ollama/ollama/commit/c16dd1fe6b1f14a464715b9c482a81760a05aae4) generic ggml.array - [`c19a5b5`](https://github.com/ollama/ollama/commit/c19a5b59ab5660acf98428b140675c0d6fb0d5c4) convert: use -1 for read all - [`298d7b3`](https://github.com/ollama/ollama/commit/298d7b3d55e2304c31b715994e05b16912dccfe2) zero means zero - [`d87461e`](https://github.com/ollama/ollama/commit/d87461e12e58686497bc26d23121dd48672603b8) fix token type - [`e8c0abc`](https://github.com/ollama/ollama/commit/e8c0abc10ceb53262c9e518bb306945abcce7ca7) update comment - [`9021ba1`](https://github.com/ollama/ollama/commit/9021ba1bd2b5e4fdcfe3f3962573062570956153) default slice values - [`7420a0d`](https://github.com/ollama/ollama/commit/7420a0d2e91090bd4347d7c91357fcb3935dd083) fix parameter count - [`8b0b65a`](https://github.com/ollama/ollama/commit/8b0b65aba4e112b5dfaf701504be89d6078e8bc9) explicitly decode maxarraysize 1024 - [`be2acf9`](https://github.com/ollama/ollama/commit/be2acf9998a9ce697d6572f49ae9178b5fd20eac) fix test ### 📊 Changes **21 files changed** (+204 additions, -164 deletions) <details> <summary>View changed files</summary> 📝 `convert/convert_test.go` (+2 -3) 📝 `fs/config.go` (+1 -1) 📝 `fs/ggml/ggml.go` (+24 -30) 📝 `fs/ggml/ggml_test.go` (+59 -0) 📝 `fs/ggml/gguf.go` (+92 -103) 📝 `llm/memory.go` (+1 -1) 📝 `model/models/gemma2/model.go` (+1 -1) 📝 `model/models/gemma3/model.go` (+1 -1) 📝 `model/models/gemma3/model_text.go` (+1 -1) 📝 `model/models/llama/model.go` (+1 -1) 📝 `model/models/mistral3/model_text.go` (+1 -1) 📝 `model/models/mllama/model.go` (+1 -1) 📝 `model/models/mllama/model_text.go` (+4 -4) 📝 `model/models/mllama/model_vision.go` (+4 -4) 📝 `model/process_text.go` (+1 -1) 📝 `model/process_text_spm_test.go` (+3 -3) 📝 `model/process_text_test.go` (+1 -1) 📝 `sample/samplers_test.go` (+1 -2) 📝 `server/create.go` (+3 -3) 📝 `server/images.go` (+1 -1) _...and 1 more files_ </details> ### 📄 Description this updates ggml.array to use generics which makes it easier to use and avoids type asserting the array values --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-22 23:44:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#39098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?