github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #9788] [MERGED] fix: correctly save in interactive mode #38933

New Issue
Closed
opened 2026-04-22 23:35:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-22 23:35:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/9788
Author: @pdevine
Created: 3/15/2025
Status: ✅ Merged
Merged: 3/15/2025
Merged by: @pdevine

Base: main ← Head: pdevine/cmd-save

📝 Commits (2)

  • 26b338a fix: correctly save in interactive mode
  • 5cbb981 linter feeding

📊 Changes

2 files changed (+139 additions, -2 deletions)

View changed files

📝 cmd/cmd_test.go (+129 -0)
📝 cmd/interactive.go (+10 -2)

📄 Description

This fixes the case where a FROM line in previous modelfile points to a file which may/may not be present in a different ollama instance. We shouldn't be relying on the filename though and instead just check if the FROM line was instead a valid model name and point to that instead.

Fixes #9573

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/9788 **Author:** [@pdevine](https://github.com/pdevine) **Created:** 3/15/2025 **Status:** ✅ Merged **Merged:** 3/15/2025 **Merged by:** [@pdevine](https://github.com/pdevine) **Base:** `main` ← **Head:** `pdevine/cmd-save` --- ### 📝 Commits (2) - [`26b338a`](https://github.com/ollama/ollama/commit/26b338a9144940caf90c3ec8ad5616e400c38577) fix: correctly save in interactive mode - [`5cbb981`](https://github.com/ollama/ollama/commit/5cbb981aa155f72c430c0d64230666d24a0b1567) linter feeding ### 📊 Changes **2 files changed** (+139 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `cmd/cmd_test.go` (+129 -0) 📝 `cmd/interactive.go` (+10 -2) </details> ### 📄 Description This fixes the case where a FROM line in previous modelfile points to a file which may/may not be present in a different ollama instance. We shouldn't be relying on the filename though and instead just check if the FROM line was instead a valid model name and point to that instead. Fixes #9573 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-22 23:35:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#38933
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?