github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #7750] [CLOSED] Disallow Tool Streaming #38382

New Issue
Closed
opened 2026-04-22 23:03:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-22 23:03:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/7750
Author: @ParthSareen
Created: 11/20/2024
Status: ❌ Closed

Base: main ← Head: parth/disallow-streaming-tools

📝 Commits (1)

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 server/routes.go (+6 -0)

📄 Description

While Tool streaming is scoped to be supported, we currently allow it, which can lead to some weird edge cases.

The tool gets added to capabilities and is passed into runner without checking if the behavior should be occurring.

807ace5b1f/server/routes.go (L1427-L1432)

The error raised now:

  File "/Users/parth/Documents/repos/ollama-python/ollama/_client.py", line 668, in inner
    raise ResponseError(e.response.text, e.response.status_code) from None
ollama._types.ResponseError: streaming is not supported with tools

I'm a bit weary of getting this PR in since people might have some work arounds for now. We could also just table this for now and it'll get fixed in the streamed tool calls PR.

Will add tests depending on what we decide.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/7750 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 11/20/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `parth/disallow-streaming-tools` --- ### 📝 Commits (1) - [`4e49d70`](https://github.com/ollama/ollama/commit/4e49d700c255d04f131c4fc2efaae524965e6e20) disallow-streaming-tools ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+6 -0) </details> ### 📄 Description While Tool streaming is scoped to be supported, we currently allow it, which can lead to some weird edge cases. The tool gets added to capabilities and is passed into runner without checking if the behavior should be occurring. https://github.com/ollama/ollama/blob/807ace5b1f4fc9de7347297b3c8a695c566d9fd9/server/routes.go#L1427-L1432 The error raised now: ``` File "/Users/parth/Documents/repos/ollama-python/ollama/_client.py", line 668, in inner raise ResponseError(e.response.text, e.response.status_code) from None ollama._types.ResponseError: streaming is not supported with tools ``` I'm a bit weary of getting this PR in since people might have some work arounds for now. We could also just table this for now and it'll get fixed in the streamed tool calls PR. Will add tests depending on what we decide. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-22 23:03:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#38382
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?