[PR #2013] [CLOSED] Add support for min_p sampling (original by @Robitx) #36629

Closed
opened 2026-04-22 21:16:02 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/2013
Author: @nathanpbell
Created: 1/16/2024
Status: Closed

Base: mainHead: main


📝 Commits (2)

  • d6bb4fb Implement @Robitx's support for min_p
  • d193d95 Add @Robitx's documentation for min_p

📊 Changes

5 files changed (+5 additions, -0 deletions)

View changed files

📝 api/types.go (+1 -0)
📝 cmd/interactive.go (+1 -0)
📝 docs/api.md (+1 -0)
📝 docs/modelfile.md (+1 -0)
📝 llm/dyn_ext_server.go (+1 -0)

📄 Description

This is a updated copy of @Robitx's pull request to add support for min_p sampling that was implemented in llama.cpp.

It differs from @Robitx's pull request in only in that it resolves the merge conflict that occurred after he submitted his original pull request. Feel free to ignore this and pull in his instead (if the merge is resolved)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/2013 **Author:** [@nathanpbell](https://github.com/nathanpbell) **Created:** 1/16/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`d6bb4fb`](https://github.com/ollama/ollama/commit/d6bb4fb04006b2f438013b38d11d10880e1f0a22) Implement @Robitx's support for min_p - [`d193d95`](https://github.com/ollama/ollama/commit/d193d95147ff9d552196e94211df201338d5ecc1) Add @Robitx's documentation for min_p ### 📊 Changes **5 files changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+1 -0) 📝 `cmd/interactive.go` (+1 -0) 📝 `docs/api.md` (+1 -0) 📝 `docs/modelfile.md` (+1 -0) 📝 `llm/dyn_ext_server.go` (+1 -0) </details> ### 📄 Description This is a updated copy of @Robitx's pull request to add support for min_p sampling that was implemented in llama.cpp. It differs from @Robitx's pull request in only in that it resolves the merge conflict that occurred after he submitted his original pull request. Feel free to ignore this and pull in his instead (if the merge is resolved) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-22 21:16:02 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#36629