github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 08:59:13 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #1921] [MERGED] fix gpu_test.go Error (same type) uint64->uint32 #36598

New Issue
Closed
opened 2026-04-22 21:14:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-22 21:14:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/1921
Author: @fpreiss
Created: 1/11/2024
Status: ✅ Merged
Merged: 1/11/2024
Merged by: @jmorganca

Base: main ← Head: fpreiss/basic_gpu_test

📝 Commits (1)

  • 99c22ed fix gpu_test.go Error (same type) uint64->uint32

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 gpu/gpu_test.go (+1 -1)

📄 Description

When running the test suite on linux with a cuda build I get the following error without this commit:

--- FAIL: TestBasicGetGPUInfo (0.06s)
    gpu_test.go:21: 
                Error Trace:    /build/ollama-cuda/src/ollama/gpu/gpu_test.go:21
                Error:          Elements should be the same type
                Test:           TestBasicGetGPUInfo
FAIL
FAIL    github.com/jmorganca/ollama/gpu 0.078s

This was due to a type mismatch between GetGPUInfo() and the corresponding TestBasicGetGPUInfo() test. This simple commit fixes it on the test side and now I get the following test output:

ok      github.com/jmorganca/ollama/gpu 0.090s

(my first line of go btw.)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/1921 **Author:** [@fpreiss](https://github.com/fpreiss) **Created:** 1/11/2024 **Status:** ✅ Merged **Merged:** 1/11/2024 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `main` ← **Head:** `fpreiss/basic_gpu_test` --- ### 📝 Commits (1) - [`99c22ed`](https://github.com/ollama/ollama/commit/99c22ed3f5f82e798cc3d9574a88d4df0b3877cd) fix gpu_test.go Error (same type) uint64->uint32 ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `gpu/gpu_test.go` (+1 -1) </details> ### 📄 Description When running the test suite on linux with a cuda build I get the following error without this commit: ```log --- FAIL: TestBasicGetGPUInfo (0.06s) gpu_test.go:21: Error Trace: /build/ollama-cuda/src/ollama/gpu/gpu_test.go:21 Error: Elements should be the same type Test: TestBasicGetGPUInfo FAIL FAIL github.com/jmorganca/ollama/gpu 0.078s ``` This was due to a type mismatch between `GetGPUInfo()` and the corresponding `TestBasicGetGPUInfo()` test. This simple commit fixes it on the test side and now I get the following test output: ```log ok github.com/jmorganca/ollama/gpu 0.090s ``` (my first line of go btw.) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-22 21:14:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#36598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?