github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #341] [MERGED] do not regenerate embeddings #35981

New Issue
Closed
opened 2026-04-22 20:43:01 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-22 20:43:01 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/341
Author: @BruceMacD
Created: 8/14/2023
Status: ✅ Merged
Merged: 8/15/2023
Merged by: @BruceMacD

Base: main ← Head: brucemacd/embed-no-regen

📝 Commits (4)

  • e9a9580 do not regenerate embeddings
  • 99b6b60 use model bin digest for embed digest
  • 2c8b680 use file info for embeddings cache
  • 18f2cb0 dont log fatal

📊 Changes

1 file changed (+49 additions, -9 deletions)

View changed files

📝 server/images.go (+49 -9)

📄 Description

  • re-use previously evaluated embeddings when possible
  • change embeddings digest identifier to be based on model name and embedded file path

This change opens previously generated embeddings for the same model/file and re-uses them when possible. This means that running create on the same file will not generate the embeddings again. This also means that only the difference between the current version of the file and the old version of the file will have the embeddings re-generated.

resolves #331
resolves #332

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/341 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 8/14/2023 **Status:** ✅ Merged **Merged:** 8/15/2023 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/embed-no-regen` --- ### 📝 Commits (4) - [`e9a9580`](https://github.com/ollama/ollama/commit/e9a9580bdd7082123f641ce58568459237ead8bd) do not regenerate embeddings - [`99b6b60`](https://github.com/ollama/ollama/commit/99b6b600857b6441302ebf94ab9171ba48de1399) use model bin digest for embed digest - [`2c8b680`](https://github.com/ollama/ollama/commit/2c8b680b036dd80fb1261f321e9d3e760321375f) use file info for embeddings cache - [`18f2cb0`](https://github.com/ollama/ollama/commit/18f2cb04722900ecac2ed2d8a483f22386c62551) dont log fatal ### 📊 Changes **1 file changed** (+49 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `server/images.go` (+49 -9) </details> ### 📄 Description - re-use previously evaluated embeddings when possible - change embeddings digest identifier to be based on model name and embedded file path This change opens previously generated embeddings for the same model/file and re-uses them when possible. This means that running create on the same file will not generate the embeddings again. This also means that only the difference between the current version of the file and the old version of the file will have the embeddings re-generated. resolves #331 resolves #332 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-22 20:43:01 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#35981
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?