[GH-ISSUE #1142] Add support for llamacpp min_p sampler #26336

Closed
opened 2026-04-22 02:33:24 -05:00 by GiteaMirror · 3 comments
Owner

Originally created by @JoseConseco on GitHub (Nov 15, 2023).
Original GitHub issue: https://github.com/ollama/ollama/issues/1142

https://github.com/ggerganov/llama.cpp/pull/3841
obraz

It supposed to give better results compared to top_k, top_p. I tried to add this min_p - parameter to llama options, but it was unrecognized.

Originally created by @JoseConseco on GitHub (Nov 15, 2023). Original GitHub issue: https://github.com/ollama/ollama/issues/1142 https://github.com/ggerganov/llama.cpp/pull/3841 ![obraz](https://github.com/jmorganca/ollama/assets/13521338/26509c9f-31a1-4544-8d8b-f3418e73a06c) It supposed to give better results compared to top_k, top_p. I tried to add this min_p - parameter to llama options, but it was unrecognized.
GiteaMirror added the feature request label 2026-04-22 02:33:24 -05:00
Author
Owner

@fast-90 commented on GitHub (Jan 6, 2024):

I would love to see this in Ollama.

<!-- gh-comment-id:1879637002 --> @fast-90 commented on GitHub (Jan 6, 2024): I would love to see this in Ollama.
Author
Owner

@Robitx commented on GitHub (Jan 6, 2024):

PR: https://github.com/jmorganca/ollama/pull/1825

<!-- gh-comment-id:1879729185 --> @Robitx commented on GitHub (Jan 6, 2024): PR: https://github.com/jmorganca/ollama/pull/1825
Author
Owner

@FellowTraveler commented on GitHub (May 22, 2024):

I think the PR needs to be rebased again because it says "can't be automatically merged."
Unless it's waiting on something else in the workflow?

<!-- gh-comment-id:2124489869 --> @FellowTraveler commented on GitHub (May 22, 2024): I think the PR needs to be rebased again because it says "can't be automatically merged." Unless it's waiting on something else in the workflow?
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#26336