github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15653] [CLOSED] cmd: improve CLI error messages for missing model name arguments #25736

New Issue
Closed
opened 2026-04-19 18:25:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 18:25:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15653
Author: @Vraj912
Created: 4/17/2026
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

  • a19a140 cmd: replace generic arg errors with descriptive messages
  • e592132 cmd: add tests for arg validation

📊 Changes

2 files changed (+107 additions, -7 deletions)

View changed files

📝 cmd/cmd.go (+34 -7)
📝 cmd/cmd_test.go (+73 -0)

📄 Description

Summary

Replaces generic argument validation errors with descriptive messages for the following commands:

  • ollama create
  • ollama show
  • ollama stop
  • ollama pull
  • ollama push
  • ollama cp

Before

Error: accepts 1 arg(s), received 0

After

Error: missing model name

For ollama cp, the error now reads: missing source and/or destination model name

When extra arguments are provided, all commands now return: extra arguments

Motivation

Users running commands like ollama show without specifying a model receive unclear error messages. Clear error messages improve UX and help users quickly understand and fix their
mistakes.

Testing

Added unit tests in cmd/cmd_test.go:

  • TestValidateModelNameArg - tests single-arg validation
  • TestValidateModelNameArgs - tests two-arg validation (cp command)

Related Issue

Closes #2893

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15653 **Author:** [@Vraj912](https://github.com/Vraj912) **Created:** 4/17/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`a19a140`](https://github.com/ollama/ollama/commit/a19a14050785d53c4f207d296e88f0866da5edd0) cmd: replace generic arg errors with descriptive messages - [`e592132`](https://github.com/ollama/ollama/commit/e59213273e053794cfec8a6fc7db71c09542637d) cmd: add tests for arg validation ### 📊 Changes **2 files changed** (+107 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `cmd/cmd.go` (+34 -7) 📝 `cmd/cmd_test.go` (+73 -0) </details> ### 📄 Description ## Summary Replaces generic argument validation errors with descriptive messages for the following commands: - `ollama create` - `ollama show` - `ollama stop` - `ollama pull` - `ollama push` - `ollama cp` ### Before Error: accepts 1 arg(s), received 0 ### After Error: missing model name For `ollama cp`, the error now reads: `missing source and/or destination model name` When extra arguments are provided, all commands now return: `extra arguments` ## Motivation Users running commands like `ollama show` without specifying a model receive unclear error messages. Clear error messages improve UX and help users quickly understand and fix their mistakes. ## Testing Added unit tests in `cmd/cmd_test.go`: - `TestValidateModelNameArg` - tests single-arg validation - `TestValidateModelNameArgs` - tests two-arg validation (cp command) ## Related Issue Closes #2893 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 18:25:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#25736
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?