github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #15124] [MERGED] launch: remove banner and warn only when backup-relevant configs change #25580

New Issue
Closed
opened 2026-04-19 18:17:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 18:17:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/15124
Author: @jmorganca
Created: 3/29/2026
Status: ✅ Merged
Merged: 3/29/2026
Merged by: @jmorganca

Base: parth-auto-save-backup ← Head: codex/minimize-launch-warning

📝 Commits (3)

  • bff77e0 launch: suppress backup warning on no-op editor writes
  • 99c49fc launch: address PR review feedback
  • 9942720 launch/opencode: set default model on integration sync

📊 Changes

6 files changed (+283 additions, -11 deletions)

View changed files

📝 cmd/launch/integrations_test.go (+67 -1)
📝 cmd/launch/launch.go (+3 -5)
📝 cmd/launch/launch_test.go (+48 -4)
📝 cmd/launch/models.go (+53 -1)
📝 cmd/launch/opencode.go (+1 -0)
📝 cmd/launch/opencode_test.go (+111 -0)

📄 Description

  • remove the Launching ... stderr banner before integration execution
  • keep editor config sync on normal editor launches (so configured pi/opencode get reapplied)
  • print the backup warning only when an existing editor-managed config file's contents actually changed
  • avoid warning on no-op rewrites and first-time file creation

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/15124 **Author:** [@jmorganca](https://github.com/jmorganca) **Created:** 3/29/2026 **Status:** ✅ Merged **Merged:** 3/29/2026 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `parth-auto-save-backup` ← **Head:** `codex/minimize-launch-warning` --- ### 📝 Commits (3) - [`bff77e0`](https://github.com/ollama/ollama/commit/bff77e0c01a0321543ecd5f840aef0605706718e) launch: suppress backup warning on no-op editor writes - [`99c49fc`](https://github.com/ollama/ollama/commit/99c49fc766cf01089e23d960877891a9e3084e63) launch: address PR review feedback - [`9942720`](https://github.com/ollama/ollama/commit/99427208bb4a45e251e48f40459bb00e7374efe1) launch/opencode: set default model on integration sync ### 📊 Changes **6 files changed** (+283 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `cmd/launch/integrations_test.go` (+67 -1) 📝 `cmd/launch/launch.go` (+3 -5) 📝 `cmd/launch/launch_test.go` (+48 -4) 📝 `cmd/launch/models.go` (+53 -1) 📝 `cmd/launch/opencode.go` (+1 -0) 📝 `cmd/launch/opencode_test.go` (+111 -0) </details> ### 📄 Description - remove the `Launching ...` stderr banner before integration execution - keep editor config sync on normal editor launches (so configured `pi`/`opencode` get reapplied) - print the backup warning only when an existing editor-managed config file's contents actually changed - avoid warning on no-op rewrites and first-time file creation --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 18:17:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#25580
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?