github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14853] [CLOSED] fix: Correct json.Unmarshal error handling logic #25415

New Issue
Closed
opened 2026-04-19 18:12:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 18:12:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14853
Author: @LincolnBurrows2017
Created: 3/14/2026
Status: ❌ Closed

Base: main ← Head: fix-json-unmarshal-logic

📝 Commits (1)

  • 22cc767 fix: correct json.Unmarshal error handling logic in openclaw.go

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 cmd/launch/openclaw.go (+3 -3)

📄 Description

Summary

Fixed 3 instances of inverted json.Unmarshal error handling logic in cmd/launch/openclaw.go:

Line Before After
182 if json.Unmarshal(data, &config) != nil if err := json.Unmarshal(data, &config); err != nil
577 if json.Unmarshal(data, &sessions) != nil if err := json.Unmarshal(data, &sessions); err != nil
660 if json.Unmarshal(data, &config) != nil if err := json.Unmarshal(data, &config); err != nil

Bug: The original logic was inverted - it returned/continued on success instead of failure.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14853 **Author:** [@LincolnBurrows2017](https://github.com/LincolnBurrows2017) **Created:** 3/14/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-json-unmarshal-logic` --- ### 📝 Commits (1) - [`22cc767`](https://github.com/ollama/ollama/commit/22cc767ae7f8a46ec5499c6609c1164e2fce5e5b) fix: correct json.Unmarshal error handling logic in openclaw.go ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `cmd/launch/openclaw.go` (+3 -3) </details> ### 📄 Description ## Summary Fixed 3 instances of inverted json.Unmarshal error handling logic in `cmd/launch/openclaw.go`: | Line | Before | After | |------|--------|-------| | 182 | `if json.Unmarshal(data, &config) != nil` | `if err := json.Unmarshal(data, &config); err != nil` | | 577 | `if json.Unmarshal(data, &sessions) != nil` | `if err := json.Unmarshal(data, &sessions); err != nil` | | 660 | `if json.Unmarshal(data, &config) != nil` | `if err := json.Unmarshal(data, &config); err != nil` | **Bug:** The original logic was inverted - it returned/continued on success instead of failure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 18:12:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#25415
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?