github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-07-16 05:05:37 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #14627] [MERGED] tui: fix signin on headless Linux systems #25295

New Issue
Closed
opened 2026-04-19 18:08:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 18:08:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14627
Author: @BruceMacD
Created: 3/4/2026
Status: ✅ Merged
Merged: 3/18/2026
Merged by: @BruceMacD

Base: main ← Head: brucemacd/signin-simplify

📝 Commits (1)

  • a7d87eb tui: fix signin on headless Linux systems

📊 Changes

3 files changed (+5 additions, -20 deletions)

View changed files

📝 cmd/launch/models.go (+4 -0)
📝 cmd/tui/signin.go (+1 -4)
📝 cmd/tui/signin_test.go (+0 -16)

📄 Description

Defensively handle environments without a display server to ensure signin remains usable on headless VMs and SSH sessions.

  • Skip calling xdg-open when neither DISPLAY nor WAYLAND_DISPLAY is set, preventing silent failures or unexpected browser handlers
  • Render the signin URL as plain text instead of wrapping it in OSC 8 hyperlink escape sequences, which can be garbled or hidden by terminals that don't support them

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14627 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 3/4/2026 **Status:** ✅ Merged **Merged:** 3/18/2026 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/signin-simplify` --- ### 📝 Commits (1) - [`a7d87eb`](https://github.com/ollama/ollama/commit/a7d87eb8281e63b08f6d8fbe682d9382875ffab6) tui: fix signin on headless Linux systems ### 📊 Changes **3 files changed** (+5 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `cmd/launch/models.go` (+4 -0) 📝 `cmd/tui/signin.go` (+1 -4) 📝 `cmd/tui/signin_test.go` (+0 -16) </details> ### 📄 Description Defensively handle environments without a display server to ensure signin remains usable on headless VMs and SSH sessions. - Skip calling xdg-open when neither DISPLAY nor WAYLAND_DISPLAY is set, preventing silent failures or unexpected browser handlers - Render the signin URL as plain text instead of wrapping it in OSC 8 hyperlink escape sequences, which can be garbled or hidden by terminals that don't support them --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 18:08:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#25295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?