github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 08:59:13 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #14430] [MERGED] mlxrunner: Fix panic on full KV cache hit #25212

New Issue
Closed
opened 2026-04-19 18:04:44 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-19 18:04:44 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/14430
Author: @jessegross
Created: 2/26/2026
Status: ✅ Merged
Merged: 2/27/2026
Merged by: @jessegross

Base: main ← Head: jessegross/mlx-fullcache

📝 Commits (1)

  • 7b82e60 mlxrunner: Fix panic on full KV cache hit

📊 Changes

2 files changed (+10 additions, -2 deletions)

View changed files

📝 x/mlxrunner/cache.go (+6 -0)
📝 x/mlxrunner/pipeline.go (+4 -2)

📄 Description

When the entire prompt was already cached (e.g. repeated prompt), findRemaining returned an empty slice, causing FromValues to panic on an index-out-of-range accessing a zero-length byte slice.

Fix by always keeping at least one token to re-evaluate so the pipeline can seed token generation. Also reject empty prompts early rather than panicking.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/14430 **Author:** [@jessegross](https://github.com/jessegross) **Created:** 2/26/2026 **Status:** ✅ Merged **Merged:** 2/27/2026 **Merged by:** [@jessegross](https://github.com/jessegross) **Base:** `main` ← **Head:** `jessegross/mlx-fullcache` --- ### 📝 Commits (1) - [`7b82e60`](https://github.com/ollama/ollama/commit/7b82e602541359423e649e0960e44952a9bded8b) mlxrunner: Fix panic on full KV cache hit ### 📊 Changes **2 files changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `x/mlxrunner/cache.go` (+6 -0) 📝 `x/mlxrunner/pipeline.go` (+4 -2) </details> ### 📄 Description When the entire prompt was already cached (e.g. repeated prompt), findRemaining returned an empty slice, causing FromValues to panic on an index-out-of-range accessing a zero-length byte slice. Fix by always keeping at least one token to re-evaluate so the pipeline can seed token generation. Also reject empty prompts early rather than panicking. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-19 18:04:44 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#25212
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?